Re: [patch 2/6] Use machine options to emulate -no-kvm-irqchip

Jan Kiszka
2012-10-03T15:46:53Z

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

On 2012-10-03 17:03, Marcelo Tosatti wrote:
> On Wed, Oct 03, 2012 at 09:40:17AM -0500, Anthony Liguori wrote:
>> Marcelo Tosatti <mtosatti@redhat.com> writes:
>>
>>> Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git.
>>>
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Upstream is moving towards this mechanism, so start using it in qemu-kvm
>>> already to configure the specific defaults: kvm enabled on, just like
>>> in-kernel irqchips.
>>>
>>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>>
>>
>> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Although it's a little odd to have From: Jan without a SoB...
>
> Agree, Jan can you ACK?

I wasn't able to join the call yesterday: Is there a removal schedule
associated with those switches? Also, why pushing things upstream, even
when only for one release, that have been loudly deprecated for a while
in qemu-kvm? Some switches are lacking deprecated warnings on the
console, and -no-kvm is missing completely. I tend to focus on patch 1 &
5, dropping the rest - based on relevance for production use.

Jan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]