From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aurelien Jarno Subject: Re: [Qemu-devel] [patch 2/6] Use machine options to emulate -no-kvm-irqchip Date: Wed, 3 Oct 2012 20:54:17 +0200 Message-ID: <20121003185417.GJ4623@ohm.aurel32.net> References: <20121003105255.972669952@amt.cnet> <20121003105509.391284251@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Anthony Liguori , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from hall.aurel32.net ([88.191.126.93]:56024 "EHLO hall.aurel32.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756529Ab2JCSyd (ORCPT ); Wed, 3 Oct 2012 14:54:33 -0400 Content-Disposition: inline In-Reply-To: <20121003105509.391284251@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 03, 2012 at 07:52:57AM -0300, Marcelo Tosatti wrote: > Commit 3ad763fcba5bd0ec5a79d4a9b6baeef119dd4a3d from qemu-kvm.git. > > From: Jan Kiszka > > Upstream is moving towards this mechanism, so start using it in qemu-kvm > already to configure the specific defaults: kvm enabled on, just like > in-kernel irqchips. > > Signed-off-by: Marcelo Tosatti > > Index: qemu-compat-kvm/vl.c > =================================================================== > --- qemu-compat-kvm.orig/vl.c > +++ qemu-compat-kvm/vl.c > @@ -3061,6 +3061,12 @@ int main(int argc, char **argv, char **e > machine = machine_parse(optarg); > } > break; > + case QEMU_OPTION_no_kvm_irqchip: { > + olist = qemu_find_opts("machine"); > + qemu_opts_parse(olist, "kernel_irqchip=off", 0); > + break; > + } > + > case QEMU_OPTION_usb: > usb_enabled = 1; > break; > Index: qemu-compat-kvm/qemu-options.hx > =================================================================== > --- qemu-compat-kvm.orig/qemu-options.hx > +++ qemu-compat-kvm/qemu-options.hx > @@ -2838,6 +2838,10 @@ STEXI > Enable FIPS 140-2 compliance mode. > ETEXI > > +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, > + "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n", > + QEMU_ARCH_I386) > + > HXCOMM This is the last statement. Insert new options before this line! > STEXI > @end table > As far as I understand, this option was not in QEMU, because this syntax is considered as deprecated. Can we also add an output a warning message in that case? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net