From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v6 05/16] target-i386: Use Hypervisor level in -machine
 pc,accel=kvm.
Date: Wed, 10 Oct 2012 11:08:05 -0300
Message-ID: <20121010140805.GA19764@amt.cnet>
References: <1348497138-2516-1-git-send-email-Don@CloudSwitch.com>
 <1348497138-2516-6-git-send-email-Don@CloudSwitch.com>
 <20121009171805.GA26004@amt.cnet>
 <20121009182726.GA27536@amt.cnet>
 <20121009184753.GA1403@amt.cnet>
 <5074765D.8000208@CloudSwitch.Com>
 <20121009191136.GD2927@amt.cnet>
 <50757218.6080503@CloudSwitch.Com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, imammedo@redhat.com,
	avi@redhat.com, afaerber@suse.de, peter.maydell@linaro.org,
	kvm@vger.kernel.org, anthony@codemonkey.ws
To: Don Slutz <Don@cloudswitch.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:23675 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756309Ab2JJOIi (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Oct 2012 10:08:38 -0400
Content-Disposition: inline
In-Reply-To: <50757218.6080503@CloudSwitch.Com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Oct 10, 2012 at 09:03:20AM -0400, Don Slutz wrote:
> >>Did you mean 3 patch sets (or more)? Or just a different order?
> >>    -Don Slutz
> >Different order. Patches should be logically related (think of what
> >information the reviewer needs). Please write changelogs for
> >every patch.
> >
> >
> Using this order causes support for Hyper-V to stop working in the
> middle of the patch set.  How about this order:
> 1) Create object properties.
> 2) Convert Hyper-V to set the new properties.
> 3) Change kvm.c to use the new properties.
> 4) Export VMWare CPUID via properties.
> 
> 5) Change accel=tcg to use the new properties.
> 
>    -Don Slutz

Fine, as long as change from item A) does not leak to item B).