Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT.

[Marcelo Tosatti <mtosatti@redhat.com>]

On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote:
> From: Cornelia Huck <cornelia.huck@de.ibm.com>
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 36befa7..c533338 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter.  (If the guest is using
>  the virtualized real-mode area (VRMA) facility, the kernel will
>  re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.)
>  
> +4.77 KVM_S390_INTERRUPT
> +
> +Capability: basic
> +Archtectures: s390

typo.

> +Type: vm ioctl, vcpu ioctl
> +Parameters: struct kvm_s390_interrupt (in)
> +Returns: 0 on success, -1 on error
> +
> +Allows to inject an interrupt to the guest. Interrupts can be floating
> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type.
> +
> +Interrupt parameters are passed via kvm_s390_interrupt:
> +
> +struct kvm_s390_interrupt {
> +	__u32 type;
> +	__u32 parm;
> +	__u64 parm64;
> +};

No need for a reserved area for extensibility?

> +
> +type can be one of the following:
> +
> +KVM_S390_SIGP_STOP (vcpu) - sigp restart
> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm
> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm
> +KVM_S390_RESTART (vcpu) - restart
> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt
> +			   parameters in parm and parm64
> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm
> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm
> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm
> +
> +Note that the vcpu ioctl is asynchronous to vpcu execution.

typo