From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 2/3] s390/kvm: Add documentation for KVM_S390_INTERRUPT. Date: Wed, 10 Oct 2012 18:38:55 +0200 Message-ID: <20121010183855.475eab15@BR9GNB5Z> References: <1349187938-39712-1-git-send-email-borntraeger@de.ibm.com> <1349187938-39712-3-git-send-email-borntraeger@de.ibm.com> <20121010162709.GA2506@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Christian Borntraeger , Avi Kivity , Jens Freimann , Heiko Carstens , Martin Schwidefsky , Heinz Graalfs , KVM To: Alexander Graf Return-path: Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:60280 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755509Ab2JJQjB (ORCPT ); Wed, 10 Oct 2012 12:39:01 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Oct 2012 17:39:00 +0100 Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q9AGcpNH57868478 for ; Wed, 10 Oct 2012 16:38:51 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q9AG2YkE022871 for ; Wed, 10 Oct 2012 12:02:35 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 10 Oct 2012 18:32:14 +0200 Alexander Graf wrote: > > On 10.10.2012, at 18:27, Marcelo Tosatti wrote: > > > On Tue, Oct 02, 2012 at 04:25:37PM +0200, Christian Borntraeger wrote: > >> From: Cornelia Huck > >> > >> Signed-off-by: Cornelia Huck > >> Signed-off-by: Martin Schwidefsky > >> Signed-off-by: Christian Borntraeger > >> --- > >> Documentation/virtual/kvm/api.txt | 33 +++++++++++++++++++++++++++++++++ > >> 1 file changed, 33 insertions(+) > >> > >> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt > >> index 36befa7..c533338 100644 > >> --- a/Documentation/virtual/kvm/api.txt > >> +++ b/Documentation/virtual/kvm/api.txt > >> @@ -1984,6 +1984,39 @@ return the hash table order in the parameter. (If the guest is using > >> the virtualized real-mode area (VRMA) facility, the kernel will > >> re-create the VMRA HPTEs on the next KVM_RUN of any vcpu.) > >> > >> +4.77 KVM_S390_INTERRUPT > >> + > >> +Capability: basic > >> +Archtectures: s390 > > > > typo. > > > >> +Type: vm ioctl, vcpu ioctl > >> +Parameters: struct kvm_s390_interrupt (in) > >> +Returns: 0 on success, -1 on error > >> + > >> +Allows to inject an interrupt to the guest. Interrupts can be floating > >> +(vm ioctl) or per cpu (vcpu ioctl), depending on the interrupt type. > >> + > >> +Interrupt parameters are passed via kvm_s390_interrupt: > >> + > >> +struct kvm_s390_interrupt { > >> + __u32 type; > >> + __u32 parm; > >> + __u64 parm64; > >> +}; > > > > No need for a reserved area for extensibility? > > This is documentation for an existing ioctl, no? > And yes, a reserved area would've been nice ;). But it's too late for that one now. Indeed. We'll have to keep this for backward compatibility and introduce a new mechanism for larger interrupt structures. > > > Alex > > > > >> + > >> +type can be one of the following: > >> + > >> +KVM_S390_SIGP_STOP (vcpu) - sigp restart > >> +KVM_S390_PROGRAM_INT (vcpu) - program check; code in parm > >> +KVM_S390_SIGP_SET_PREFIX (vcpu) - sigp set prefix; prefix address in parm > >> +KVM_S390_RESTART (vcpu) - restart > >> +KVM_S390_INT_VIRTIO (vm) - virtio external interrupt; external interrupt > >> + parameters in parm and parm64 > >> +KVM_S390_INT_SERVICE (vm) - sclp external interrupt; sclp parameter in parm > >> +KVM_S390_INT_EMERGENCY (vcpu) - sigp emergency; source cpu in parm > >> +KVM_S390_INT_EXTERNAL_CALL (vcpu) - sigp external call; source cpu in parm > >> + > >> +Note that the vcpu ioctl is asynchronous to vpcu execution. > > > > typo > > > > >