Re: [PATCH v4 5/5] KVM: MMU: introduce FNAME(prefetch_gpte)

Xiao Guangrong
2012-10-11T13:12:51Z

On 10/10/2012 11:21 PM, Marcelo Tosatti wrote:

>> pgprintk("%s: gpte %llx spte %p\n", __func__, (u64)gpte, spte);
>> +
>> + gfn = gpte_to_gfn(gpte);
>> pte_access = sp->role.access & gpte_access(vcpu, gpte);
>> protect_clean_gpte(&pte_access, gpte);
>> - pfn = gfn_to_pfn_atomic(vcpu->kvm, gpte_to_gfn(gpte));
>> + pfn = pte_prefetch_gfn_to_pfn(vcpu, gfn,
>> + no_dirty_log && (pte_access & ACC_WRITE_MASK));
>
> Is this a bugfix?

No. It is a cleanup.

Actually, pte_prefetch_gfn_to_pfn(vcpu, gfn, false) is the same as
gfn_to_pfn_atomic