From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: RFC: Move kvm's instruction decoding into generic code. Date: Wed, 24 Oct 2012 17:27:58 +0100 Message-ID: <20121024162758.GB2005@linaro.org> References: <20121022174555.GD26619@mudshark.cambridge.arm.com> <1351077923-17977-1-git-send-email-rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Will Deacon , Christoffer Dall , "kvm@vger.kernel.org" To: Rusty Russell Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:44940 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933634Ab2JXQ2D (ORCPT ); Wed, 24 Oct 2012 12:28:03 -0400 Received: by mail-bk0-f46.google.com with SMTP id jk13so354289bkc.19 for ; Wed, 24 Oct 2012 09:28:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1351077923-17977-1-git-send-email-rusty@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 24, 2012 at 09:55:13PM +1030, Rusty Russell wrote: > Compile-tested only, but shows what it looks like (ugly). > > I just used the existing code and didn't crack open my ARM books to > determine if there's a better way. The struct names are pretty vague, > too, as a result. > Thanks (to you and Christoffer) for having a stab at this. I'll try to respond to these patches, but I have a recorsive panic going on here so it may take a bit of time... Cheers ---Dave