From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH 00/15] QEMU KVM_GET_SUPPORTED_CPUID cleanups and fixes Date: Wed, 24 Oct 2012 15:54:09 -0200 Message-ID: <20121024175409.GA8231@otherpad.lan.raisama.net> References: <1349383747-19383-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , Avi Kivity , Igor Mammedov , Andreas =?iso-8859-1?Q?F=E4rber?= To: qemu-devel@nongnu.org Return-path: Content-Disposition: inline In-Reply-To: <1349383747-19383-1-git-send-email-ehabkost@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Has anybody looked at this series? Avi, Marcelo? On Thu, Oct 04, 2012 at 05:48:52PM -0300, Eduardo Habkost wrote: > Most of this series are just cleanups that will help when making -cpu > check/enforce work properly, with some fixes. > > In addition to code movements, the main changes are: > - x2apic won't be enabled if in-kernel irqchip is disabled > (patch 10) > - CPUID feature bit filtering is done much earlier, and inside target-i386/cpu.c > (patch 13) > - CPUID leaf 7 feature bits are now filterd based on GET_SUPPORTED_CPUID too > (patch 15) > > Eduardo Habkost (15): > i386: kvm: kvm_arch_get_supported_cpuid: move R_EDX hack outside of > for loop > i386: kvm: kvm_arch_get_supported_cpuid: clean up has_kvm_features > check > i386: kvm: kvm_arch_get_supported_cpuid: use 'entry' variable > i386: kvm: extract register switch to cpuid_entry_get_reg() function > i386: kvm: extract CPUID entry lookup to cpuid_find_entry() function > i386: kvm: extract try_get_cpuid() loop to get_supported_cpuid() > function > i386: kvm: kvm_arch_get_supported_cpuid: replace if+switch with > single 'if' > i386: kvm: set CPUID_EXT_HYPERVISOR on kvm_arch_get_supported_cpuid() > i386: kvm: set CPUID_EXT_TSC_DEADLINE_TIMER on > kvm_arch_get_supported_cpuid() > i386: kvm: x2apic is not supported without in-kernel irqchip > i386: kvm: mask cpuid_kvm_features earlier > i386: kvm: mask cpuid_ext4_features bits earlier > i386: kvm: filter CPUID feature words earlier, on cpu.c > i386: kvm: reformat filter_features_for_kvm() code > i386: kvm: filter CPUID leaf 7 based on GET_SUPPORTED_CPUID, too > > kvm.h | 1 + > target-i386/cpu.c | 30 +++++++++++ > target-i386/kvm.c | 153 ++++++++++++++++++++++++++++++++---------------------- > 3 files changed, 122 insertions(+), 62 deletions(-) > > -- > 1.7.11.4 > > -- Eduardo