From: William Dauchy <william@gandi.net>
To: Pekka Enberg <penberg@kernel.org>
Cc: William Dauchy <william@gandi.net>,
kvm@vger.kernel.org, levinsasha928@gmail.com, mingo@kernel.org,
asias.hejun@gmail.com, gorcunov@openvz.org
Subject: Re: [PATCH 1/5] kvm tools: check ioctl return value for msi signal
Date: Thu, 25 Oct 2012 11:15:41 +0200 [thread overview]
Message-ID: <20121025091541.GA9291@gandi.net> (raw)
In-Reply-To: <alpine.LFD.2.02.1210250955480.28934@tux.localdomain>
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
On Oct25 10:01, Pekka Enberg wrote:
> Is this something that happens on your machine? I wonder if it makes more
> sense to return the error from virtio_pci__signal_vq() and
> virtio_pci__signal_config() and make the callers deal with it.
no but I thought it was worth not keeping a system call unchecked;
particularly when you are debugging something (ballooning in my case),
just wanted to make sure the call was indeed ok.
--
William
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-25 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 12:51 [PATCH 0/5] kvm tools: virtio-balloon fix and cleaning William Dauchy
2012-10-24 12:51 ` [PATCH 1/5] kvm tools: check ioctl return value for msi signal William Dauchy
2012-10-25 7:01 ` Pekka Enberg
2012-10-25 9:15 ` William Dauchy [this message]
2012-10-25 19:18 ` Sasha Levin
2012-10-24 12:51 ` [PATCH 2/5] kvm tools: use the correct config vector interrupt William Dauchy
2012-10-25 7:03 ` Pekka Enberg
2012-10-25 19:20 ` Sasha Levin
2012-10-26 15:29 ` Pekka Enberg
2012-10-24 12:51 ` [PATCH 3/5] kvm tools: correctly handle mem ballooning William Dauchy
2012-10-24 17:43 ` Sasha Levin
2012-10-24 17:50 ` William Dauchy
2012-10-24 12:51 ` [PATCH 4/5] kvm tools: initialize msi flags to zero even is not used yet William Dauchy
2012-10-25 7:07 ` Pekka Enberg
2012-10-25 9:17 ` William Dauchy
2012-10-24 12:51 ` [PATCH 5/5] kvm tools: specify the amount to balloon is in MB William Dauchy
2012-10-25 7:10 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025091541.GA9291@gandi.net \
--to=william@gandi.net \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@openvz.org \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).