From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [patch 09/16] x86: kvm guest: pvclock vsyscall support Date: Mon, 5 Nov 2012 06:35:14 -0200 Message-ID: <20121105083513.GA7739@logos.redhat.com> References: <20121031224656.417434866@redhat.com> <20121031224824.243464587@redhat.com> <50939591.7000809@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, johnstul@us.ibm.com, jeremy@goop.org, zamsden@gmail.com, gleb@redhat.com, avi@redhat.com, pbonzini@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983Ab2KEIfq (ORCPT ); Mon, 5 Nov 2012 03:35:46 -0500 Content-Disposition: inline In-Reply-To: <50939591.7000809@parallels.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 02, 2012 at 01:42:41PM +0400, Glauber Costa wrote: > On 11/01/2012 02:47 AM, Marcelo Tosatti wrote: > > + info = pvclock_get_vsyscall_time_info(cpu); > > + > > + low = (int)__pa(info) | 1; > > + high = ((u64)__pa(&per_cpu(hv_clock, cpu)) >> 32); > > + ret = native_write_msr_safe(MSR_KVM_USERSPACE_TIME, low, high); > > + printk(KERN_INFO "kvm-clock: cpu %d, msr %x:%x, %s\n", > > + cpu, high, low, txt); > > + > > Why do you put info in the lower half, and the hv_clock in the higher half ? Copy&paste bug. Fixed, thanks.