Re: [kvmarm] [PATCH v4 09/14] KVM: ARM: Emulation framework and CP15 emulation

Rusty Russell
2012-11-20T09:48:18Z

Peter Maydell <peter.maydell@linaro.org> writes:
> On 19 November 2012 15:01, Will Deacon <will.deacon@arm.com> wrote:
>> On Sat, Nov 10, 2012 at 03:43:13PM +0000, Christoffer Dall wrote:
>>> +/*
>>> + * A15-specific CP15 registers.
>>> + * Important: Must be sorted ascending by CRn, CRM, Op1, Op2
>>> + */
>>> +static const struct coproc_reg a15_regs[] = {
>>> + /* MPIDR: we use VMPIDR for guest access. */
>>> + { CRn( 0), CRm( 0), Op1( 0), Op2( 5), is32,
>>> + NULL, reset_mpidr, c0_MPIDR },
>>> +
>>> + /* SCTLR: swapped by interrupt.S. */
>>> + { CRn( 1), CRm( 0), Op1( 0), Op2( 0), is32,
>>> + NULL, reset_val, c1_SCTLR, 0x00C50078 },
>>
>> Why is the SCTLR included here as an A15-specific register?
>
> Rusty might remember the exact answer, but probably because
> the SCTLR reset value is IMPDEF.

Indeed...

Cheers,
Rusty.