From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v2 4/4] nested vmx: use a list to store the launched
 vmcs12 for L1 VMM
Date: Tue, 27 Nov 2012 22:29:08 -0200
Message-ID: <20121128002908.GD8295@amt.cnet>
References: <1353559919-29439-1-git-send-email-dongxiao.xu@intel.com>
 <1353559919-29439-5-git-send-email-dongxiao.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, gleb@redhat.com
To: Dongxiao Xu <dongxiao.xu@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:16971 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754355Ab2K1Asg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 27 Nov 2012 19:48:36 -0500
Content-Disposition: inline
In-Reply-To: <1353559919-29439-5-git-send-email-dongxiao.xu@intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 22, 2012 at 12:51:59PM +0800, Dongxiao Xu wrote:
> The launch state is not a member in the VMCS area, use a separate
> variable (list) to store it instead.
> 
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>

1. What is the problem with keeping launched state in the VMCS?
Assuming there is a positive answer to the above:

2. Don't you have to change VMCS ID?

3. Can't it be kept somewhere else other than a list? Current scheme 
allows guest to allocate unlimited amounts of host memory.

4. What is the state of migration / nested vmx again? If vmcs12 is
migrated, this means launched state is not migrated anymore.

Patches 1-3 seem fine.