[kvm:queue 23/25] arch/s390/kvm/kvm-s390.c:358:6: error: conflicting types for 'kvm_arch_vcpu_postcreate'

[kvm:queue 23/25] arch/s390/kvm/kvm-s390.c:358:6: error: conflicting types for 'kvm_arch_vcpu_postcreate'

[Fengguang Wu]

Hi Marcelo,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
head:   fc1ddea318fa2c1ac3d496d8653ca4bc9b66e679
commit: 438d76a60e7be59a558f8712a47565fa8258d17d [23/25] KVM: x86: add kvm_arch_vcpu_postcreate callback, move TSC initialization
config: make ARCH=s390 allmodconfig

All error/warnings:

arch/s390/kvm/kvm-s390.c:358:6: error: conflicting types for 'kvm_arch_vcpu_postcreate'
In file included from arch/s390/kvm/kvm-s390.c:22:0:
include/linux/kvm_host.h:599:5: note: previous declaration of 'kvm_arch_vcpu_postcreate' was here
arch/s390/kvm/kvm-s390.c: In function 'kvm_arch_vcpu_postcreate':
arch/s390/kvm/kvm-s390.c:360:2: warning: 'return' with a value, in function returning void [enabled by default]

vim +358 +/kvm_arch_vcpu_postcreate arch/s390/kvm/kvm-s390.c

b0c632db Heiko Carstens        2008-03-25  352  	vcpu->arch.guest_fpregs.fpc = 0;
b0c632db Heiko Carstens        2008-03-25  353  	asm volatile("lfpc %0" : : "Q" (vcpu->arch.guest_fpregs.fpc));
b0c632db Heiko Carstens        2008-03-25  354  	vcpu->arch.sie_block->gbea = 1;
61bde82c Christian Borntraeger 2012-06-11  355  	atomic_set_mask(CPUSTAT_STOPPED, &vcpu->arch.sie_block->cpuflags);
b0c632db Heiko Carstens        2008-03-25  356  }
b0c632db Heiko Carstens        2008-03-25  357  
438d76a6 Marcelo Tosatti       2012-11-19 @358  void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)
438d76a6 Marcelo Tosatti       2012-11-19  359  {
438d76a6 Marcelo Tosatti       2012-11-19 @360  	return 0;
438d76a6 Marcelo Tosatti       2012-11-19  361  }
438d76a6 Marcelo Tosatti       2012-11-19  362  
b0c632db Heiko Carstens        2008-03-25  363  int kvm_arch_vcpu_setup(struct kvm_vcpu *vcpu)

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Re: [kvm:queue 23/25] arch/s390/kvm/kvm-s390.c:358:6: error: conflicting types for 'kvm_arch_vcpu_postcreate'

[Marcelo Tosatti]

On Tue, Nov 27, 2012 at 10:56:50AM +0800, Fengguang Wu wrote:
> 
> Hi Marcelo,
> 
> FYI, kernel build failed on
> 
> tree:   git://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
> head:   fc1ddea318fa2c1ac3d496d8653ca4bc9b66e679
> commit: 438d76a60e7be59a558f8712a47565fa8258d17d [23/25] KVM: x86: add kvm_arch_vcpu_postcreate callback, move TSC initialization
> config: make ARCH=s390 allmodconfig

Fengguang Wu,

Thanks. Repository has been updated, it would be good
if you can rerun the tests.

Re: [kvm:queue 23/25] arch/s390/kvm/kvm-s390.c:358:6: error: conflicting types for 'kvm_arch_vcpu_postcreate'

[Fengguang Wu]

On Tue, Nov 27, 2012 at 11:51:19PM -0200, Marcelo Tosatti wrote:
> On Tue, Nov 27, 2012 at 10:56:50AM +0800, Fengguang Wu wrote:
> > 
> > Hi Marcelo,
> > 
> > FYI, kernel build failed on
> > 
> > tree:   git://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
> > head:   fc1ddea318fa2c1ac3d496d8653ca4bc9b66e679
> > commit: 438d76a60e7be59a558f8712a47565fa8258d17d [23/25] KVM: x86: add kvm_arch_vcpu_postcreate callback, move TSC initialization
> > config: make ARCH=s390 allmodconfig
> 
> Fengguang Wu,
> 
> Thanks. Repository has been updated, it would be good
> if you can rerun the tests.

Marcelo, the build log shows that the new kvm/queue head
d98d07ca7e0347d712d54a865af323c4aee04bc2 builds fine. :)

Thanks,
Fengguang