kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>,
	gleb@redhat.com, mtosatti@redhat.com
Cc: kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCHv4 0/2] kvm: direct msix injection
Date: Wed, 28 Nov 2012 13:19:56 +0200	[thread overview]
Message-ID: <20121128111956.GA15496@redhat.com> (raw)
In-Reply-To: <1354077297.1809.189.camel@bling.home>

On Tue, Nov 27, 2012 at 09:34:57PM -0700, Alex Williamson wrote:
> On Wed, 2012-11-21 at 21:26 +0200, Michael S. Tsirkin wrote:
> > On Wed, Oct 17, 2012 at 06:05:53PM +0200, Michael S. Tsirkin wrote:
> > > We can deliver certain interrupts, notably MSIX,
> > > from atomic context.
> > > Here's an untested patch to do this (compiled only).
> > > 
> > > Changes from v2:
> > > Don't inject broadcast interrupts directly
> > > Changes from v1:
> > > Tried to address comments from v1, except unifying
> > > with kvm_set_irq: passing flags to it looks too ugly.
> > > Added a comment.
> > > 
> > > Jan, you said you can test this?
> > 
> > I have tested this with some networking workloads
> > and this patchset seems to work fine.
> > My setup isn't a good fit for benchmarking device
> > assignment though.
> > Alex, could you pls verifyu that this solves the
> > latency issue that you sometimes observe?
> > With this patchset device assignment latency should be
> > as fast as vfio.
> 
> Yep, that seems to cover the gap.  My environment is too noisy to
> declare an absolute winner, but pci-assign and vfio-pci are now very,
> very similar under netperf TCP_RR with these patches.  Thanks,
> 
> Alex

Thanks very much for the report.
Gleb, Marcelo, ACK?
Also please add
Tested-by: Alex Williamson <alex.williamson@redhat.com>

-- 
MST

  reply	other threads:[~2012-11-28 11:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 16:05 [PATCHv4 0/2] kvm: direct msix injection Michael S. Tsirkin
2012-10-17 16:06 ` [PATCHv4 1/2] kvm: add kvm_set_irq_inatomic Michael S. Tsirkin
2012-10-17 16:06 ` [PATCHv4 2/2] kvm: deliver msi interrupts from irq handler Michael S. Tsirkin
2012-11-28 11:43   ` Gleb Natapov
2012-11-28 11:56     ` Michael S. Tsirkin
2012-11-28 12:13       ` Gleb Natapov
2012-11-28 12:22         ` Michael S. Tsirkin
2012-11-28 12:45           ` Gleb Natapov
2012-11-28 13:25             ` Michael S. Tsirkin
2012-11-28 13:38               ` Gleb Natapov
2012-11-28 15:25                 ` Michael S. Tsirkin
2012-11-28 15:25                   ` Gleb Natapov
2012-11-21 19:26 ` [PATCHv4 0/2] kvm: direct msix injection Michael S. Tsirkin
2012-11-28  4:34   ` Alex Williamson
2012-11-28 11:19     ` Michael S. Tsirkin [this message]
2012-12-05 13:12 ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121128111956.GA15496@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).