From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: MMU: lazily drop large spte
Date: Wed, 28 Nov 2012 09:39:30 -0200
Message-ID: <20121128113930.GA29825@amt.cnet>
References: <20121114143747.GA7054@amt.cnet>
 <50A4267B.1030902@linux.vnet.ibm.com>
 <20121116030222.GA21822@amt.cnet>
 <50A5B560.2070604@linux.vnet.ibm.com>
 <20121116035655.GA27414@amt.cnet>
 <50A5C518.7030002@linux.vnet.ibm.com>
 <20121116095752.GA21401@amt.cnet>
 <50A799DA.7050900@linux.vnet.ibm.com>
 <20121118030040.GA5334@amt.cnet>
 <50B5A0CA.8060807@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	KVM <kvm@vger.kernel.org>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <50B5A0CA.8060807@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, Nov 28, 2012 at 01:27:38PM +0800, Xiao Guangrong wrote:
> On 11/18/2012 11:00 AM, Marcelo Tosatti wrote:
> map gfn 4?  See corrected step 7 above.
> >>
> >> Ah, this is a real bug, and unfortunately, it exists in current
> >> code. I will make a separate patchset to fix it. Thank you, Marcelo!
> > 
> > Is it? Hum..
> > 
> > Anyway, it would be great if you can write a testcase (should be similar
> > in size to rmap_chain).
> 
> Marcelo, is this patch acceptable?

Yes, can we get reexecute_instruction fix first? (which should then be
able to handle the case where a large read-only spte is created).

I'll merge the testcase later today.