From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] KVM: use is_idle_task() instead of idle_cpu() to decide when to halt in async_pf Date: Wed, 28 Nov 2012 21:30:45 -0200 Message-ID: <20121128233045.GA16986@amt.cnet> References: <20121128131908.GE928@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Frederic Weisbecker , Li Zhong To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745Ab2K2AXW (ORCPT ); Wed, 28 Nov 2012 19:23:22 -0500 Content-Disposition: inline In-Reply-To: <20121128131908.GE928@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Nov 28, 2012 at 03:19:08PM +0200, Gleb Natapov wrote: > As Frederic pointed idle_cpu() may return false even if async fault > happened in the idle task if wake up is pending. In this case the code > will try to put idle task to sleep. Fix this by using is_idle_task() to > check for idle task. > > Reported-by: Frederic Weisbecker > Signed-off-by: Gleb Natapov Applied, thanks.