From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support
Date: Thu, 29 Nov 2012 18:43:51 -0200
Message-ID: <20121129204350.GC27255@amt.cnet>
References: <1354043340.4613.6.camel@WillAuldHomeLinux>
 <20121128010017.GG8295@amt.cnet>
 <96EC5A4F3149B74492D2D9B9B1602C2728BB05FE@ORSMSX108.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Dugger, Donald D" <donald.d.dugger@intel.com>,
	"Liu, Jinsong" <jinsong.liu@intel.com>,
	"Zhang, Xiantao" <xiantao.zhang@intel.com>,
	"avi@redhat.com" <avi@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>, Gleb <gleb@redhat.com>
To: "Auld, Will" <will.auld@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54071 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753975Ab2K2Un7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 29 Nov 2012 15:43:59 -0500
Content-Disposition: inline
In-Reply-To: <96EC5A4F3149B74492D2D9B9B1602C2728BB05FE@ORSMSX108.amr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 29, 2012 at 07:21:28PM +0000, Auld, Will wrote:
> Marcelo,
> 
> The behavior on reset is to return the TSC_AJUST msr value to 0x0. I am currently initializing this emulated msr in kvm_arch_vcpu_init(). 

Will,

Reset is handled by QEMU. kvm_arch_vcpu_init is only called during vcpu
allocation (ie vm creation). See x86_cpu_reset in QEMU's
target-i386/cpu.c file.

> 
> >- Behaviour on reset: what is the behaviour on RESET?
> 
> I am testing the rebase now. I would like to get any needed changes for this initialization into my next patch set version (v6) if possible.

For the kernel patch, everything is fine. Apparently for the QEMU patch
it is  necessary to set value to zero on reset.