From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 2/2] KVM: VMX: fix memory order between loading vmcs and clearing vmcs Date: Thu, 29 Nov 2012 21:15:39 -0200 Message-ID: <20121129231539.GA7409@amt.cnet> References: <50B6093B.7040404@linux.vnet.ibm.com> <50B60976.7020905@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Gleb Natapov , LKML , KVM To: Xiao Guangrong Return-path: Content-Disposition: inline In-Reply-To: <50B60976.7020905@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Nov 28, 2012 at 08:54:14PM +0800, Xiao Guangrong wrote: > vmcs->cpu indicates whether it exists on the target cpu, -1 means the vmcs > does not exist on any vcpu > > If vcpu load vmcs with vmcs.cpu = -1, it can be directly added to cpu's percpu > list. The list can be corrupted if the cpu prefetch the vmcs's list before > reading vmcs->cpu. Meanwhile, we should remove vmcs from the list before > making vmcs->vcpu == -1 be visible > > Signed-off-by: Xiao Guangrong > --- > arch/x86/kvm/vmx.c | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) Applied, thanks.