From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3 3/4] x86, apicv: add virtual interrupt delivery support
Date: Tue, 4 Dec 2012 18:46:45 +0200
Message-ID: <20121204164644.GA13745@redhat.com>
References: <1354518064-3066-1-git-send-email-yang.z.zhang@intel.com>
 <1354518064-3066-4-git-send-email-yang.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, gleb@redhat.com,
	Kevin Tian <kevin.tian@intel.com>
To: Yang Zhang <yang.z.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:16843 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753732Ab2LDQoE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 4 Dec 2012 11:44:04 -0500
Content-Disposition: inline
In-Reply-To: <1354518064-3066-4-git-send-email-yang.z.zhang@intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Dec 03, 2012 at 03:01:03PM +0800, Yang Zhang wrote:
> +		int vector = -1;
nitpicking: no need to initialize vector here

> +
> +		if (kvm_apic_vid_enabled(vcpu))
> +			vector = kvm_cpu_get_extint(vcpu);
> +		else
> +			vector = kvm_cpu_get_interrupt(vcpu);