[PATCH] kvm: Fix irqfd resampler list walk

[PATCH] kvm: Fix irqfd resampler list walk

[Alex Williamson]

Typo for the next pointer means we're walking random data here.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: stable@vger.kernel.org [3.7]
---

Not sure if this will make 3.7, so preemptively adding the stable flag

 virt/kvm/eventfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index 9718e98..62e7bd6 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -332,7 +332,7 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
 		mutex_lock(&kvm->irqfds.resampler_lock);
 
 		list_for_each_entry(resampler,
-				    &kvm->irqfds.resampler_list, list) {
+				    &kvm->irqfds.resampler_list, link) {
 			if (resampler->notifier.gsi == irqfd->gsi) {
 				irqfd->resampler = resampler;
 				break;

Re: [PATCH] kvm: Fix irqfd resampler list walk

[Marcelo Tosatti]

On Thu, Dec 06, 2012 at 02:44:59PM -0700, Alex Williamson wrote:
> Typo for the next pointer means we're walking random data here.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> Cc: stable@vger.kernel.org [3.7]
> ---
> 
> Not sure if this will make 3.7, so preemptively adding the stable flag
> 
>  virt/kvm/eventfd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Re: [PATCH] kvm: Fix irqfd resampler list walk

[Alex Williamson]

On Mon, 2012-12-10 at 18:16 -0200, Marcelo Tosatti wrote:
> On Thu, Dec 06, 2012 at 02:44:59PM -0700, Alex Williamson wrote:
> > Typo for the next pointer means we're walking random data here.
> > 
> > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > Cc: stable@vger.kernel.org [3.7]
> > ---
> > 
> > Not sure if this will make 3.7, so preemptively adding the stable flag
> > 
> >  virt/kvm/eventfd.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks.
> 

Hi Marcelo,

This didn't seem to make it into 3.7.0 or any stable 3.7.  Can we
promote it for stable?  Thanks,

Alex

Re: [PATCH] kvm: Fix irqfd resampler list walk

[Marcelo Tosatti]

On Mon, Jan 28, 2013 at 08:25:00AM -0700, Alex Williamson wrote:
> On Mon, 2012-12-10 at 18:16 -0200, Marcelo Tosatti wrote:
> > On Thu, Dec 06, 2012 at 02:44:59PM -0700, Alex Williamson wrote:
> > > Typo for the next pointer means we're walking random data here.
> > > 
> > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > > Cc: stable@vger.kernel.org [3.7]
> > > ---
> > > 
> > > Not sure if this will make 3.7, so preemptively adding the stable flag
> > > 
> > >  virt/kvm/eventfd.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Applied, thanks.
> > 
> 
> Hi Marcelo,
> 
> This didn't seem to make it into 3.7.0 or any stable 3.7.  Can we
> promote it for stable?  Thanks,
> 
> Alex

Yes, please send the patch with the backport you're interested in being
included to stable@kernel.org.

http://www.kernel.org/doc/Documentation/stable_kernel_rules.txt