kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: mtosatti@redhat.com, gleb@redhat.com
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH 09/10] kvm: struct kvm_memory_slot.id -> short
Date: Thu, 06 Dec 2012 15:21:20 -0700	[thread overview]
Message-ID: <20121206222120.24968.66982.stgit@bling.home> (raw)
In-Reply-To: <20121206214722.24968.6043.stgit@bling.home>

We're currently offering a whopping 32 memory slots to user space, an
int is a bit excessive for storing this.  We would like to increase
our memslots, but SHRT_MAX should be more than enough.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 include/linux/kvm_host.h |    4 ++--
 virt/kvm/kvm_main.c      |    2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 641f5fb..87089dd 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -255,7 +255,7 @@ struct kvm_memory_slot {
 	struct kvm_arch_memory_slot arch;
 	unsigned long userspace_addr;
 	u32 flags;
-	int id;
+	short id;
 	bool user_alloc;
 };
 
@@ -315,7 +315,7 @@ struct kvm_memslots {
 	u64 generation;
 	struct kvm_memory_slot memslots[KVM_MEM_SLOTS_NUM];
 	/* The mapping table from slot id to the index in memslots[]. */
-	int id_to_index[KVM_MEM_SLOTS_NUM];
+	short id_to_index[KVM_MEM_SLOTS_NUM];
 };
 
 struct kvm {
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 6eeb101..6e4709f 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -469,6 +469,8 @@ static struct kvm *kvm_create_vm(unsigned long type)
 	INIT_HLIST_HEAD(&kvm->irq_ack_notifier_list);
 #endif
 
+	BUILD_BUG_ON(KVM_MEM_SLOTS_NUM > SHRT_MAX);
+
 	r = -ENOMEM;
 	kvm->memslots = kzalloc(sizeof(struct kvm_memslots), GFP_KERNEL);
 	if (!kvm->memslots)

  parent reply	other threads:[~2012-12-06 22:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06 22:20 [PATCH 00/10] kvm: memory slot cleanups, fix, and increase Alex Williamson
2012-12-06 22:20 ` [PATCH 01/10] kvm: Restrict non-existing slot state transitions Alex Williamson
2012-12-06 22:20 ` [PATCH 02/10] kvm: Check userspace_addr when modifying a memory slot Alex Williamson
2012-12-07 18:17   ` Jason Baron
2012-12-07 18:32     ` Alex Williamson
2012-12-07 18:44       ` Jason Baron
2012-12-06 22:20 ` [PATCH 03/10] kvm: Fix iommu map/unmap to handle memory slot moves Alex Williamson
2012-12-06 22:20 ` [PATCH 04/10] kvm: Minor memory slot optimization Alex Williamson
2012-12-06 22:20 ` [PATCH 05/10] kvm: Rename KVM_MEMORY_SLOTS -> KVM_USER_MEM_SLOTS Alex Williamson
2012-12-06 22:21 ` [PATCH 06/10] kvm: Make KVM_PRIVATE_MEM_SLOTS optional Alex Williamson
2012-12-06 22:21 ` [PATCH 07/10] kvm: struct kvm_memory_slot.user_alloc -> bool Alex Williamson
2012-12-06 22:21 ` [PATCH 08/10] kvm: struct kvm_memory_slot.flags -> u32 Alex Williamson
2012-12-06 22:21 ` Alex Williamson [this message]
2012-12-06 22:21 ` [PATCH 10/10] kvm: Increase user memory slots on x86 to 125 Alex Williamson
2012-12-07 14:02   ` Takuya Yoshikawa
2012-12-07 16:09     ` Alex Williamson
2012-12-10 13:48       ` Takuya Yoshikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121206222120.24968.66982.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).