From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 5/5] KVM: s390: Split out early console code. Date: Tue, 11 Dec 2012 13:36:11 +0100 Message-ID: <20121211133611.57193191@BR9GNB5Z> References: <1354883369-36537-1-git-send-email-cornelia.huck@de.ibm.com> <1354883369-36537-6-git-send-email-cornelia.huck@de.ibm.com> <20121210100631.160cd7bc@BR9GNB5Z> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Gleb Natapov , KVM , linux-s390 , Avi Kivity , Christian Borntraeger , Carsten Otte , Heiko Carstens , Martin Schwidefsky , Sebastian Ott To: Alexander Graf Return-path: Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:60163 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608Ab2LKMgS (ORCPT ); Tue, 11 Dec 2012 07:36:18 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Dec 2012 12:36:04 -0000 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 11 Dec 2012 11:10:39 +0100 Alexander Graf wrote: > > On 10.12.2012, at 10:06, Cornelia Huck wrote: > > > On Sun, 9 Dec 2012 13:45:47 +0100 > > Alexander Graf wrote: > > > >> > >> On 07.12.2012, at 13:29, Cornelia Huck wrote: > >> > >>> This code is transport agnostic and can be used by both the legacy > >>> virtio code and virtio_ccw. > >> > >> This code should die. It's a nightmare to implement in QEMU, because it ends up being a separate char device. I'd prefer if we don't carry it over to the virtio-ccw world :). > > > > I don't really want to kill an interface in a patchset adding a new > > transport. We may kill this later on, though... > > I fully agree :). What I was trying to say is "leave this to die in the old code and don't bother about it in the new world order". Removing support for the old kvm virtio machine is nothing for today. Ah, OK. I'll merge the return -ENODEV into the first patch then and drop this one.