From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH 3/8] s390: I/O interrupt and machine check injection. Date: Tue, 11 Dec 2012 13:50:10 +0100 Message-ID: <20121211135010.36872984@BR9GNB5Z> References: <1354884626-15060-1-git-send-email-cornelia.huck@de.ibm.com> <1354884626-15060-4-git-send-email-cornelia.huck@de.ibm.com> <82610216-94CA-44E8-B3CE-EB94886CECFC@suse.de> <20121210112726.0697bc4f@BR9GNB5Z> <7338881F-11E8-4C21-BB81-E02F65DDB73D@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: qemu-devel , KVM , linux-s390 , Marcelo Tosatti , Gleb Natapov , Anthony Liguori , Christian Borntraeger , Carsten Otte , Heiko Carstens , Martin Schwidefsky , Sebastian Ott To: Alexander Graf Return-path: Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:37447 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001Ab2LKMuV (ORCPT ); Tue, 11 Dec 2012 07:50:21 -0500 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Dec 2012 12:50:05 -0000 In-Reply-To: <7338881F-11E8-4C21-BB81-E02F65DDB73D@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 11 Dec 2012 11:29:16 +0100 Alexander Graf wrote: > > On 10.12.2012, at 11:27, Cornelia Huck wrote: > > > On Mon, 10 Dec 2012 09:20:57 +0100 > > Alexander Graf wrote: > > > >> > >> On 07.12.2012, at 13:50, Cornelia Huck wrote: > >>> + /* CRW machine checks disabled */ > >>> + return; > >>> + } > >>> + > >>> + lowcore = cpu_physical_memory_map(env->psa, &len, 1); > >> > >> Check missing again. > > > > Perhaps we want {map,unmap}_lowcore() functions? > > Awesome idea! I'll cook up an extra patch for this then (and make the ext stuff use it).