From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Date: Wed, 12 Dec 2012 12:54:49 +0200 Message-ID: <20121212105449.GM11016@redhat.com> References: <1355288712-26899-1-git-send-email-yang.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Yang Zhang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62353 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181Ab2LLKyv (ORCPT ); Wed, 12 Dec 2012 05:54:51 -0500 Content-Disposition: inline In-Reply-To: <1355288712-26899-1-git-send-email-yang.z.zhang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Dec 12, 2012 at 01:05:12PM +0800, Yang Zhang wrote: > From: Yang Zhang > > This hack is wrong. The pin number of PIT is connected to > 2 not 0. This means this hack never takes effect. So it is ok > to remove it. > > Signed-off-by: Yang Zhang Acked-by: Gleb Natapov > --- > virt/kvm/ioapic.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c > index cfb7e4d..f3abbef 100644 > --- a/virt/kvm/ioapic.c > +++ b/virt/kvm/ioapic.c > @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq) > irqe.level = 1; > irqe.shorthand = 0; > > -#ifdef CONFIG_X86 > - /* Always delivery PIT interrupt to vcpu 0 */ > - if (irq == 0) { > - irqe.dest_mode = 0; /* Physical mode. */ > - /* need to read apic_id from apic regiest since > - * it can be rewritten */ > - irqe.dest_id = ioapic->kvm->bsp_vcpu_id; > - } > -#endif > return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe); > } > > -- > 1.7.1 -- Gleb.