From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v7 2/3] x86, apicv: add virtual interrupt delivery support
Date: Thu, 20 Dec 2012 11:01:42 -0200
Message-ID: <20121220130142.GC7750@amt.cnet>
References: <1355722250-7122-1-git-send-email-yang.z.zhang@intel.com>
 <1355722250-7122-3-git-send-email-yang.z.zhang@intel.com>
 <20121220012630.GA29185@amt.cnet>
 <20121220065132.GD17584@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Yang Zhang <yang.z.zhang@intel.com>, kvm@vger.kernel.org,
	haitao.shan@intel.com, Kevin Tian <kevin.tian@intel.com>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:59773 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751220Ab2LTNCz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 20 Dec 2012 08:02:55 -0500
Content-Disposition: inline
In-Reply-To: <20121220065132.GD17584@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Dec 20, 2012 at 08:51:32AM +0200, Gleb Natapov wrote:
> On Wed, Dec 19, 2012 at 11:26:30PM -0200, Marcelo Tosatti wrote:
> > On Mon, Dec 17, 2012 at 01:30:49PM +0800, Yang Zhang wrote:
> > > From: Yang Zhang <yang.z.zhang@Intel.com>
> > > 
> > > Virtual interrupt delivery avoids KVM to inject vAPIC interrupts
> > > manually, which is fully taken care of by the hardware. This needs
> > > some special awareness into existing interrupr injection path:
> > > 
> > > - for pending interrupt, instead of direct injection, we may need
> > >   update architecture specific indicators before resuming to guest.
> > > 
> > > - A pending interrupt, which is masked by ISR, should be also
> > >   considered in above update action, since hardware will decide
> > >   when to inject it at right time. Current has_interrupt and
> > >   get_interrupt only returns a valid vector from injection p.o.v.
> > > 
> > > Signed-off-by: Kevin Tian <kevin.tian@intel.com>
> > > Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
> > 
> > > +	if (enable_apicv_reg_vid)
> > > +		kvm_x86_ops->update_cr8_intercept = NULL;
> > > +	else
> > > +		kvm_x86_ops->update_apic_irq = NULL;
> > 
> > Loading the module with enable_apicv=0, then enable_apicv=1, 
> > fails?
> It is not changeable after modules is loaded. This is true for all
> kvm-intel.ko parameters.

Are you sure? Works just fine here.