From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 0/7] Fix emulate_invalid_guest_state=0 part 2 Date: Sat, 22 Dec 2012 09:05:29 +0200 Message-ID: <20121222070529.GU29007@redhat.com> References: <1355332255-26612-1-git-send-email-gleb@redhat.com> <20121221235529.GB30710@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43802 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832Ab2LVHFb (ORCPT ); Sat, 22 Dec 2012 02:05:31 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBM75Vsp027929 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 22 Dec 2012 02:05:31 -0500 Content-Disposition: inline In-Reply-To: <20121221235529.GB30710@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 21, 2012 at 09:55:29PM -0200, Marcelo Tosatti wrote: > On Wed, Dec 12, 2012 at 07:10:48PM +0200, Gleb Natapov wrote: > > emulate_invalid_guest_state=0 still does not work since last patch of > > my previous series was not applied. It causes kvm to emulate code that > > previously kvm managed to run in vm86 and this, in turn, causes emulation > > errors for instructions kvm does not know how to emulate. Patch 2 of > > the series should fix that. Patch 3 is exactly same as 4/4 from previous > > series. Other patches are clean-ups. > > Can't see how guest_state_valid() can affect > emulate_invalid_guest_state=0. > Patch 3/7 fixes it. Patch 2/7 is needed for 3/7 to not break emulate_invalid_guest_state=1. > For the cleanups, Reviewed-by: Marcelo Tosatti . -- Gleb.