From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 1/7] KVM: x86 emulator: framework for streamlining arithmetic opcodes Date: Sat, 22 Dec 2012 20:01:17 +0200 Message-ID: <20121222180117.GA29007@redhat.com> References: <1356179217-5526-1-git-send-email-avi.kivity@gmail.com> <1356179217-5526-2-git-send-email-avi.kivity@gmail.com> <20121222170003.GZ29007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000Ab2LVSBc (ORCPT ); Sat, 22 Dec 2012 13:01:32 -0500 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Dec 22, 2012 at 07:42:55PM +0200, Avi Kivity wrote: > On Sat, Dec 22, 2012 at 7:00 PM, Gleb Natapov wrote: > > On Sat, Dec 22, 2012 at 02:26:51PM +0200, Avi Kivity wrote: > >> + > >> +/* > >> + * fastop functions have a special calling convention: > >> + * > >> + * dst: [rdx]:rax (in/out) > > May be I miss something obvious but I do not see why rdx is here. > > MUL, DIV, CWD, etc. Yes, but my question was more about actual fastop() implementation which does not seams to handle rdx at all. -- Gleb.