From: Gleb Natapov <gleb@redhat.com>
To: Yang Zhang <yang.z.zhang@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0
Date: Sun, 23 Dec 2012 10:05:00 +0200 [thread overview]
Message-ID: <20121223080500.GK17584@redhat.com> (raw)
In-Reply-To: <1355288712-26899-1-git-send-email-yang.z.zhang@intel.com>
On Wed, Dec 12, 2012 at 01:05:12PM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> This hack is wrong. The pin number of PIT is connected to
> 2 not 0. This means this hack never takes effect. So it is ok
> to remove it.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
Thanks, applied.
> ---
> virt/kvm/ioapic.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index cfb7e4d..f3abbef 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
> irqe.level = 1;
> irqe.shorthand = 0;
>
> -#ifdef CONFIG_X86
> - /* Always delivery PIT interrupt to vcpu 0 */
> - if (irq == 0) {
> - irqe.dest_mode = 0; /* Physical mode. */
> - /* need to read apic_id from apic regiest since
> - * it can be rewritten */
> - irqe.dest_id = ioapic->kvm->bsp_vcpu_id;
> - }
> -#endif
> return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe);
> }
>
> --
> 1.7.1
--
Gleb.
prev parent reply other threads:[~2012-12-23 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 5:05 [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Yang Zhang
2012-12-12 10:54 ` Gleb Natapov
2012-12-23 8:05 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121223080500.GK17584@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).