* [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0
@ 2012-12-12 5:05 Yang Zhang
2012-12-12 10:54 ` Gleb Natapov
2012-12-23 8:05 ` Gleb Natapov
0 siblings, 2 replies; 3+ messages in thread
From: Yang Zhang @ 2012-12-12 5:05 UTC (permalink / raw)
To: kvm; +Cc: gleb, Yang Zhang
From: Yang Zhang <yang.z.zhang@Intel.com>
This hack is wrong. The pin number of PIT is connected to
2 not 0. This means this hack never takes effect. So it is ok
to remove it.
Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
---
virt/kvm/ioapic.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index cfb7e4d..f3abbef 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
irqe.level = 1;
irqe.shorthand = 0;
-#ifdef CONFIG_X86
- /* Always delivery PIT interrupt to vcpu 0 */
- if (irq == 0) {
- irqe.dest_mode = 0; /* Physical mode. */
- /* need to read apic_id from apic regiest since
- * it can be rewritten */
- irqe.dest_id = ioapic->kvm->bsp_vcpu_id;
- }
-#endif
return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0
2012-12-12 5:05 [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Yang Zhang
@ 2012-12-12 10:54 ` Gleb Natapov
2012-12-23 8:05 ` Gleb Natapov
1 sibling, 0 replies; 3+ messages in thread
From: Gleb Natapov @ 2012-12-12 10:54 UTC (permalink / raw)
To: Yang Zhang; +Cc: kvm
On Wed, Dec 12, 2012 at 01:05:12PM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> This hack is wrong. The pin number of PIT is connected to
> 2 not 0. This means this hack never takes effect. So it is ok
> to remove it.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
Acked-by: Gleb Natapov <gleb@redhat.com>
> ---
> virt/kvm/ioapic.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index cfb7e4d..f3abbef 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
> irqe.level = 1;
> irqe.shorthand = 0;
>
> -#ifdef CONFIG_X86
> - /* Always delivery PIT interrupt to vcpu 0 */
> - if (irq == 0) {
> - irqe.dest_mode = 0; /* Physical mode. */
> - /* need to read apic_id from apic regiest since
> - * it can be rewritten */
> - irqe.dest_id = ioapic->kvm->bsp_vcpu_id;
> - }
> -#endif
> return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe);
> }
>
> --
> 1.7.1
--
Gleb.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0
2012-12-12 5:05 [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Yang Zhang
2012-12-12 10:54 ` Gleb Natapov
@ 2012-12-23 8:05 ` Gleb Natapov
1 sibling, 0 replies; 3+ messages in thread
From: Gleb Natapov @ 2012-12-23 8:05 UTC (permalink / raw)
To: Yang Zhang; +Cc: kvm
On Wed, Dec 12, 2012 at 01:05:12PM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> This hack is wrong. The pin number of PIT is connected to
> 2 not 0. This means this hack never takes effect. So it is ok
> to remove it.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
Thanks, applied.
> ---
> virt/kvm/ioapic.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index cfb7e4d..f3abbef 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -179,15 +179,6 @@ static int ioapic_deliver(struct kvm_ioapic *ioapic, int irq)
> irqe.level = 1;
> irqe.shorthand = 0;
>
> -#ifdef CONFIG_X86
> - /* Always delivery PIT interrupt to vcpu 0 */
> - if (irq == 0) {
> - irqe.dest_mode = 0; /* Physical mode. */
> - /* need to read apic_id from apic regiest since
> - * it can be rewritten */
> - irqe.dest_id = ioapic->kvm->bsp_vcpu_id;
> - }
> -#endif
> return kvm_irq_delivery_to_apic(ioapic->kvm, NULL, &irqe);
> }
>
> --
> 1.7.1
--
Gleb.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-23 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-12 5:05 [PATCH] KVM: remove a wrong hack of delivery PIT intr to vcpu0 Yang Zhang
2012-12-12 10:54 ` Gleb Natapov
2012-12-23 8:05 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).