From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] access: add test for dirty bit tracking if CR0.WP = 0
Date: Tue, 15 Jan 2013 09:47:08 +0200
Message-ID: <20130115074708.GH11529@redhat.com>
References: <50CC20C4.1010206@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>, KVM <kvm@vger.kernel.org>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:63965 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750892Ab3AOHsq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 15 Jan 2013 02:48:46 -0500
Content-Disposition: inline
In-Reply-To: <50CC20C4.1010206@linux.vnet.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sat, Dec 15, 2012 at 03:03:32PM +0800, Xiao Guangrong wrote:
> If the write-fault access is from supervisor and CR0.WP is not set on the
> vcpu, kvm will fix it by adjusting pte access - it sets the W bit on pte
> and clears U bit. This is the chance that kvm can change pte access from
> readonly to writable
> 
> Unfortunately, the pte access is the access of 'direct' shadow page table,
> means direct sp.role.access = pte_access, then we will create a writable
> spte entry on the readonly shadow page table. It will cause Dirty bit is
> not tracked when two guest ptes point to the same large page. Note, it
> does not have other impact except Dirty bit since cr0.wp is encoded into
> sp.role
> 
> This testcast is not to to trigger this bug
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Applied, thanks.

> ---
>  x86/access.c |   55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 55 insertions(+), 0 deletions(-)
> 
> diff --git a/x86/access.c b/x86/access.c
> index 23a5995..2ca325a 100644
> --- a/x86/access.c
> +++ b/x86/access.c
> @@ -687,6 +687,60 @@ err:
>      return 0;
>  }
> 
> +/*
> + * If the write-fault access is from supervisor and CR0.WP is not set on the
> + * vcpu, kvm will fix it by adjusting pte access - it sets the W bit on pte
> + * and clears U bit. This is the chance that kvm can change pte access from
> + * readonly to writable.
> + *
> + * Unfortunately, the pte access is the access of 'direct' shadow page table,
> + * means direct sp.role.access = pte_access, then we will create a writable
> + * spte entry on the readonly shadow page table. It will cause Dirty bit is
> + * not tracked when two guest ptes point to the same large page. Note, it
> + * does not have other impact except Dirty bit since cr0.wp is encoded into
> + * sp.role.
> + *
> + * Note: to trigger this bug, hugepage should be disabled on host.
> + */
> +static int check_large_pte_dirty_for_nowp(ac_pool_t *pool)
> +{
> +	ac_test_t at1, at2;
> +
> +	ac_test_init(&at1, (void *)(0x123403000000));
> +	ac_test_init(&at2, (void *)(0x666606000000));
> +
> +	at2.flags[AC_PDE_PRESENT] = 1;
> +	at2.flags[AC_PDE_PSE] = 1;
> +
> +	ac_test_setup_pte(&at2, pool);
> +	if (!ac_test_do_access(&at2)) {
> +		printf("%s: read on the first mapping fail.\n", __FUNCTION__);
> +		goto err;
> +	}
> +
> +	at1.flags[AC_PDE_PRESENT] = 1;
> +	at1.flags[AC_PDE_PSE] = 1;
> +	at1.flags[AC_ACCESS_WRITE] = 1;
> +
> +	ac_test_setup_pte(&at1, pool);
> +	if (!ac_test_do_access(&at1)) {
> +		printf("%s: write on the second mapping fail.\n", __FUNCTION__);
> +		goto err;
> +	}
> +
> +	at2.flags[AC_ACCESS_WRITE] = 1;
> +	ac_set_expected_status(&at2);
> +	if (!ac_test_do_access(&at2)) {
> +		printf("%s: write on the first mapping fail.\n", __FUNCTION__);
> +		goto err;
> +	}
> +
> +	return 1;
> +
> +err:
> +	return 0;
> +}
> +
>  static int check_smep_andnot_wp(ac_pool_t *pool)
>  {
>  	ac_test_t at1;
> @@ -756,6 +810,7 @@ const ac_test_fn ac_test_cases[] =
>  {
>  	corrupt_hugepage_triger,
>  	check_pfec_on_prefetch_pte,
> +	check_large_pte_dirty_for_nowp,
>  	check_smep_andnot_wp
>  };
> 
> -- 
> 1.7.7.6

--
			Gleb.