From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-spec: set mac address by a new vq command
Date: Wed, 16 Jan 2013 11:22:23 +0200 [thread overview]
Message-ID: <20130116092223.GC12723@redhat.com> (raw)
In-Reply-To: <20130116091328.GA6931@stefanha-thinkpad.redhat.com>
On Wed, Jan 16, 2013 at 10:13:28AM +0100, Stefan Hajnoczi wrote:
> On Wed, Jan 16, 2013 at 03:33:24PM +0800, akong@redhat.com wrote:
> > +\change_inserted -1930653948 1358320004
> > +The command VIRTIO_NET_CTRL_MAC_ADDR_SET is used to set
> > +\begin_inset Quotes eld
> > +\end_inset
> > +
> > +physical
> > +\begin_inset Quotes erd
> > +\end_inset
> > +
> > + address of the network card.
>
> The "physical" address of the network card? That term is not defined
> anywhere in the specification.
>
> Perhaps it's best to explain that the config space "mac" field and
> VIRTIO_NET_CTRL_MAC_ADDR_SET both set the default MAC address which rx
> filtering accepts. (The MAC table is an additional set of MAC addresses
> which rx filtering accepts.)
>
> It would also be worth explaining that VIRTIO_NET_CTRL_MAC_ADDR_SET is
> atomic whereas the config space "mac" field is not. Therefore,
> VIRTIO_NET_CTRL_MAC_ADDR_SET is preferred, especially while the NIC is
> up.
>
> Stefan
It's probably best to simply make the config space field
read-only if the feature bit is acked.
next prev parent reply other threads:[~2013-01-16 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 7:33 [PATCH] virtio-spec: set mac address by a new vq command akong
2013-01-16 9:13 ` Stefan Hajnoczi
2013-01-16 9:22 ` Michael S. Tsirkin [this message]
2013-01-17 6:34 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116092223.GC12723@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=stefanha@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox