From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] kvm: close opened file
Date: Wed, 16 Jan 2013 13:35:22 +0200
Message-ID: <20130116113522.GR11529@redhat.com>
References: <1358298456-18377-1-git-send-email-dinggnu@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Asias He <asias.hejun@gmail.com>, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Cong Ding <dinggnu@gmail.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1358298456-18377-1-git-send-email-dinggnu@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Please use "kvmtool:" prefix at the subject line.

On Wed, Jan 16, 2013 at 02:07:35AM +0100, Cong Ding wrote:
> The file should be closed before return.
> 
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
>  tools/kvm/builtin-setup.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/kvm/builtin-setup.c b/tools/kvm/builtin-setup.c
> index c5b0566..8b45c56 100644
> --- a/tools/kvm/builtin-setup.c
> +++ b/tools/kvm/builtin-setup.c
> @@ -159,12 +159,12 @@ static int copy_passwd(const char *guestfs_name)
>  		return -1;
>  
>  	ret = fprintf(file, "root:x:0:0:root:/root:/bin/sh\n");
> -	if (ret < 0)
> -		return ret;
> +	if (ret > 0)
> +		ret = 0;
>  
>  	fclose(file);
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static int make_guestfs_symlink(const char *guestfs_name, const char *path)
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.