From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: [kbuild] [vfio:vfio-vga 3/5] drivers/vfio/pci/vfio_pci_rdwr.c:169 vfio_pci_bar_rw() warn: always true condition '(done >= 0) => (0-u32max >= 0)' Date: Thu, 17 Jan 2013 09:21:01 +0800 Message-ID: <20130117012101.GB7017@localhost> References: <50f70feb.ZSR7zBYc69/bckGk%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mga01.intel.com ([192.55.52.88]:11884 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757388Ab3AQBVZ (ORCPT ); Wed, 16 Jan 2013 20:21:25 -0500 Content-Disposition: inline In-Reply-To: <50f70feb.ZSR7zBYc69/bckGk%fengguang.wu@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Alex, FYI, there are new smatch warnings show up in tree: git://github.com/awilliam/linux-vfio.git vfio-vga head: 2c2e21fa66c40ed7b8e434c86a9f2ab0c879f21d commit: f4d38f216ef420595d12f74b256b3961eb4c3c14 [3/5] vfio-pci: Cleanup BAR access New smatch warnings: drivers/vfio/pci/vfio_pci_rdwr.c:169 vfio_pci_bar_rw() warn: always true condition '(done >= 0) => (0-u32max >= 0)' vim +169 drivers/vfio/pci/vfio_pci_rdwr.c f4d38f21 Alex Williamson 2013-01-16 153 if (!io) { f4d38f21 Alex Williamson 2013-01-16 154 pci_release_selected_regions(pdev, 1 << bar); f4d38f21 Alex Williamson 2013-01-16 155 return -ENOMEM; 89e1f7d4 Alex Williamson 2012-07-31 156 } 89e1f7d4 Alex Williamson 2012-07-31 157 f4d38f21 Alex Williamson 2013-01-16 158 vdev->barmap[bar] = io; f4d38f21 Alex Williamson 2013-01-16 159 } else 89e1f7d4 Alex Williamson 2012-07-31 160 io = vdev->barmap[bar]; 89e1f7d4 Alex Williamson 2012-07-31 161 f4d38f21 Alex Williamson 2013-01-16 162 if (bar == vdev->msix_bar) { f4d38f21 Alex Williamson 2013-01-16 163 x_start = vdev->msix_offset; f4d38f21 Alex Williamson 2013-01-16 164 x_end = vdev->msix_offset + vdev->msix_size; 89e1f7d4 Alex Williamson 2012-07-31 165 } 89e1f7d4 Alex Williamson 2012-07-31 166 f4d38f21 Alex Williamson 2013-01-16 167 done = do_io_rw(io, buf, pos, count, x_start, x_end, iswrite); 89e1f7d4 Alex Williamson 2012-07-31 168 f4d38f21 Alex Williamson 2013-01-16 @169 if (done >= 0) f4d38f21 Alex Williamson 2013-01-16 170 *ppos += done; 89e1f7d4 Alex Williamson 2012-07-31 171 89e1f7d4 Alex Williamson 2012-07-31 172 if (bar == PCI_ROM_RESOURCE) 89e1f7d4 Alex Williamson 2012-07-31 173 pci_unmap_rom(pdev, io); 89e1f7d4 Alex Williamson 2012-07-31 174 f4d38f21 Alex Williamson 2013-01-16 175 return done; 89e1f7d4 Alex Williamson 2012-07-31 176 } --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation _______________________________________________ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild