From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi.kivity@gmail.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 8/8] KVM: x86 emulator: convert a few freestanding emulations to fastop
Date: Thu, 17 Jan 2013 11:44:13 +0200 [thread overview]
Message-ID: <20130117094413.GH11529@redhat.com> (raw)
In-Reply-To: <1358001177-8952-9-git-send-email-avi.kivity@gmail.com>
Missing Signed-off-by :(
On Sat, Jan 12, 2013 at 04:32:57PM +0200, Avi Kivity wrote:
> ---
> arch/x86/kvm/emulate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index da2b903..1bb0af2 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2209,7 +2209,7 @@ static int em_cmpxchg(struct x86_emulate_ctxt *ctxt)
> /* Save real source value, then compare EAX against destination. */
> ctxt->src.orig_val = ctxt->src.val;
> ctxt->src.val = reg_read(ctxt, VCPU_REGS_RAX);
> - emulate_2op_SrcV(ctxt, "cmp");
> + fastop(ctxt, em_cmp);
>
> if (ctxt->eflags & EFLG_ZF) {
> /* Success: write back to memory. */
> @@ -2977,7 +2977,7 @@ static int em_das(struct x86_emulate_ctxt *ctxt)
> ctxt->src.type = OP_IMM;
> ctxt->src.val = 0;
> ctxt->src.bytes = 1;
> - emulate_2op_SrcV(ctxt, "or");
> + fastop(ctxt, em_or);
> ctxt->eflags &= ~(X86_EFLAGS_AF | X86_EFLAGS_CF);
> if (cf)
> ctxt->eflags |= X86_EFLAGS_CF;
> @@ -4816,7 +4816,7 @@ twobyte_insn:
> (s16) ctxt->src.val;
> break;
> case 0xc0 ... 0xc1: /* xadd */
> - emulate_2op_SrcV(ctxt, "add");
> + fastop(ctxt, em_add);
> /* Write back the register source. */
> ctxt->src.val = ctxt->dst.orig_val;
> write_register_operand(&ctxt->src);
> --
> 1.8.0.1
--
Gleb.
prev parent reply other threads:[~2013-01-17 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 14:32 [PATCH 0/8] More fastop patches Avi Kivity
2013-01-12 14:32 ` [PATCH 1/8] KVM: x86 emulator: Streamline SHLD, SHRD Avi Kivity
2013-01-17 8:45 ` Gleb Natapov
2013-01-12 14:32 ` [PATCH 2/8] KVM: x86 emulator: convert shift/rotate instructions to fastop Avi Kivity
2013-01-12 14:32 ` [PATCH 3/8] KVM: x86 emulator: covert SETCC " Avi Kivity
2013-01-17 9:42 ` Gleb Natapov
2013-01-12 14:32 ` [PATCH 4/8] KVM: x86 emulator: convert INC/DEC " Avi Kivity
2013-01-12 14:32 ` [PATCH 5/8] KVM: x86 emulator: convert BT/BTS/BTR/BTC/BSF/BSR " Avi Kivity
2013-01-12 14:32 ` [PATCH 6/8] KVM: x86 emulator: convert 2-operand IMUL " Avi Kivity
2013-01-12 14:32 ` [PATCH 7/8] KVM: x86 emulator: rearrange fastop definitions Avi Kivity
2013-01-12 14:32 ` [PATCH 8/8] KVM: x86 emulator: convert a few freestanding emulations to fastop Avi Kivity
2013-01-17 9:44 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117094413.GH11529@redhat.com \
--to=gleb@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox