From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Yang Zhang <yang.z.zhang@intel.com>,
kvm@vger.kernel.org, haitao.shan@intel.com,
xiantao.zhang@intel.com, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v11 3/3] x86, apicv: add virtual interrupt delivery support
Date: Mon, 21 Jan 2013 23:18:28 +0200 [thread overview]
Message-ID: <20130121211828.GG25818@redhat.com> (raw)
In-Reply-To: <20130121210543.GA7110@amt.cnet>
On Mon, Jan 21, 2013 at 07:05:43PM -0200, Marcelo Tosatti wrote:
> > + struct vcpu_vmx *vmx = to_vmx(vcpu);
> > +
> > + if (WARN_ONCE((vector > 255),
> > + "KVM VMX: vector (%d) out of range\n", vector))
> > + return;
>
> Please remove the WARN_ON, inject triple fault if this happens
> (and add a tracepoint).
>
Since this cannot be triggered by a guest triple fault is unwarranted.
Vector can be greater than 255 here only due to KVM bug, so WARN() or
even BUG() is appropriate.
--
Gleb.
next prev parent reply other threads:[~2013-01-21 21:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 10:21 [PATCH v11 0/3] x86, apicv: Add APIC virtualization support Yang Zhang
2013-01-16 10:21 ` [PATCH v11 1/3] x86, apicv: add APICv register " Yang Zhang
2013-01-16 10:21 ` [PATCH v11 2/3] x86, apicv: add virtual x2apic support Yang Zhang
2013-01-17 13:22 ` Gleb Natapov
2013-01-18 1:49 ` Zhang, Yang Z
2013-01-21 19:59 ` Marcelo Tosatti
2013-01-21 20:21 ` Gleb Natapov
2013-01-21 21:21 ` Marcelo Tosatti
2013-01-21 21:34 ` Gleb Natapov
2013-01-21 22:16 ` Marcelo Tosatti
2013-01-22 0:33 ` Marcelo Tosatti
2013-01-22 3:37 ` Zhang, Yang Z
2013-01-22 9:45 ` Gleb Natapov
2013-01-22 9:42 ` Gleb Natapov
2013-01-22 12:21 ` Zhang, Yang Z
2013-01-22 15:55 ` Gleb Natapov
2013-01-22 23:13 ` Marcelo Tosatti
2013-01-23 0:35 ` Zhang, Yang Z
2013-01-23 10:29 ` Gleb Natapov
2013-01-16 10:21 ` [PATCH v11 3/3] x86, apicv: add virtual interrupt delivery support Yang Zhang
2013-01-17 1:26 ` Zhang, Yang Z
2013-01-20 12:51 ` Gleb Natapov
2013-01-21 0:49 ` Zhang, Yang Z
2013-01-21 5:03 ` Gleb Natapov
2013-01-21 7:18 ` Zhang, Yang Z
2013-01-21 21:08 ` Marcelo Tosatti
2013-01-23 0:45 ` Zhang, Yang Z
2013-01-23 10:33 ` Gleb Natapov
2013-01-23 10:52 ` Zhang, Yang Z
2013-01-21 21:05 ` Marcelo Tosatti
2013-01-21 21:18 ` Gleb Natapov [this message]
2013-01-21 21:54 ` Marcelo Tosatti
2013-01-22 3:38 ` Zhang, Yang Z
2013-01-16 10:27 ` [PATCH v11 0/3] x86, apicv: Add APIC virtualization support Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121211828.GG25818@redhat.com \
--to=gleb@redhat.com \
--cc=haitao.shan@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox