* [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
@ 2013-01-17 23:48 Alexander Graf
2013-01-17 23:48 ` [PATCH 1/1] KVM: PPC: Emulate dcbf Alexander Graf
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Alexander Graf @ 2013-01-17 23:48 UTC (permalink / raw)
To: kvm-ppc; +Cc: kvm
Hi Marcelo / Gleb,
This is my current patch queue for ppc against 3.8. Please pull.
It contains a bug fix for an issue that Ben Collins ran into, where
a guest would just abort because it traps during an unknown instruction.
Alex
The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
Linus Torvalds (1):
Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs
are available in the git repository at:
git://github.com/agraf/linux-2.6.git kvm-ppc-3.8
Alexander Graf (1):
KVM: PPC: Emulate dcbf
arch/powerpc/kvm/emulate.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] KVM: PPC: Emulate dcbf
2013-01-17 23:48 [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Alexander Graf
@ 2013-01-17 23:48 ` Alexander Graf
2013-01-18 10:55 ` [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Gleb Natapov
2013-01-21 23:36 ` Marcelo Tosatti
2 siblings, 0 replies; 10+ messages in thread
From: Alexander Graf @ 2013-01-17 23:48 UTC (permalink / raw)
To: kvm-ppc; +Cc: kvm, stable
Guests can trigger MMIO exits using dcbf. Since we don't emulate cache
incoherent MMIO, just do nothing and move on.
Reported-by: Ben Collins <ben.c@servergy.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
Tested-by: Ben Collins <ben.c@servergy.com>
CC: stable@vger.kernel.org
---
arch/powerpc/kvm/emulate.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
index b0855e5..9d9cddc 100644
--- a/arch/powerpc/kvm/emulate.c
+++ b/arch/powerpc/kvm/emulate.c
@@ -39,6 +39,7 @@
#define OP_31_XOP_TRAP 4
#define OP_31_XOP_LWZX 23
#define OP_31_XOP_TRAP_64 68
+#define OP_31_XOP_DCBF 86
#define OP_31_XOP_LBZX 87
#define OP_31_XOP_STWX 151
#define OP_31_XOP_STBX 215
@@ -374,6 +375,7 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
emulated = kvmppc_emulate_mtspr(vcpu, sprn, rs);
break;
+ case OP_31_XOP_DCBF:
case OP_31_XOP_DCBI:
/* Do nothing. The guest is performing dcbi because
* hardware DMA is not snooped by the dcache, but
--
1.6.0.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-17 23:48 [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Alexander Graf
2013-01-17 23:48 ` [PATCH 1/1] KVM: PPC: Emulate dcbf Alexander Graf
@ 2013-01-18 10:55 ` Gleb Natapov
2013-01-18 12:14 ` Alexander Graf
2013-01-21 23:36 ` Marcelo Tosatti
2 siblings, 1 reply; 10+ messages in thread
From: Gleb Natapov @ 2013-01-18 10:55 UTC (permalink / raw)
To: Alexander Graf; +Cc: kvm-ppc, kvm
On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
> Hi Marcelo / Gleb,
>
> This is my current patch queue for ppc against 3.8. Please pull.
>
> It contains a bug fix for an issue that Ben Collins ran into, where
> a guest would just abort because it traps during an unknown instruction.
>
Is this regression from 3.7? If it is not it should wait for 3.9.
> Alex
>
>
> The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
> Linus Torvalds (1):
> Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs
>
> are available in the git repository at:
>
> git://github.com/agraf/linux-2.6.git kvm-ppc-3.8
>
> Alexander Graf (1):
> KVM: PPC: Emulate dcbf
>
> arch/powerpc/kvm/emulate.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-18 10:55 ` [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Gleb Natapov
@ 2013-01-18 12:14 ` Alexander Graf
2013-01-18 12:23 ` Ben Collins
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Graf @ 2013-01-18 12:14 UTC (permalink / raw)
To: Gleb Natapov; +Cc: kvm-ppc, KVM list, ben.c
On 18.01.2013, at 11:55, Gleb Natapov wrote:
> On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
>> Hi Marcelo / Gleb,
>>
>> This is my current patch queue for ppc against 3.8. Please pull.
>>
>> It contains a bug fix for an issue that Ben Collins ran into, where
>> a guest would just abort because it traps during an unknown instruction.
>>
> Is this regression from 3.7? If it is not it should wait for 3.9.
The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.
Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-18 12:14 ` Alexander Graf
@ 2013-01-18 12:23 ` Ben Collins
2013-01-21 10:40 ` Gleb Natapov
0 siblings, 1 reply; 10+ messages in thread
From: Ben Collins @ 2013-01-18 12:23 UTC (permalink / raw)
To: Alexander Graf; +Cc: Gleb Natapov, kvm-ppc, KVM list
On Jan 18, 2013, at 7:14 AM, Alexander Graf <agraf@suse.de> wrote:
>
> On 18.01.2013, at 11:55, Gleb Natapov wrote:
>
>> On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
>>> Hi Marcelo / Gleb,
>>>
>>> This is my current patch queue for ppc against 3.8. Please pull.
>>>
>>> It contains a bug fix for an issue that Ben Collins ran into, where
>>> a guest would just abort because it traps during an unknown instruction.
>>>
>> Is this regression from 3.7? If it is not it should wait for 3.9.
>
> The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.
It's such a simple change, what is the issue with including it? If the bug is hit, qemu/kvm exits anyway, so adding the patch can't do any damage.
--
Ben Collins - Principal Architect
Servergy, Inc. - www.servergy.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-18 12:23 ` Ben Collins
@ 2013-01-21 10:40 ` Gleb Natapov
2013-01-21 12:15 ` Ben Collins
0 siblings, 1 reply; 10+ messages in thread
From: Gleb Natapov @ 2013-01-21 10:40 UTC (permalink / raw)
To: Ben Collins; +Cc: Alexander Graf, kvm-ppc, KVM list
On Fri, Jan 18, 2013 at 07:23:53AM -0500, Ben Collins wrote:
> On Jan 18, 2013, at 7:14 AM, Alexander Graf <agraf@suse.de> wrote:
>
> >
> > On 18.01.2013, at 11:55, Gleb Natapov wrote:
> >
> >> On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
> >>> Hi Marcelo / Gleb,
> >>>
> >>> This is my current patch queue for ppc against 3.8. Please pull.
> >>>
> >>> It contains a bug fix for an issue that Ben Collins ran into, where
> >>> a guest would just abort because it traps during an unknown instruction.
> >>>
> >> Is this regression from 3.7? If it is not it should wait for 3.9.
> >
> > The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.
>
> It's such a simple change, what is the issue with including it? If the bug is hit, qemu/kvm exits anyway, so adding the patch can't do any damage.
>
If we continue pushing simple changes that can't do any damage to
late -rc trees 3.8 will never be ready to released. The patch can go to
stable after 3.8 is released. Again if this is indeed regression this
another matter.
--
Gleb.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-21 10:40 ` Gleb Natapov
@ 2013-01-21 12:15 ` Ben Collins
0 siblings, 0 replies; 10+ messages in thread
From: Ben Collins @ 2013-01-21 12:15 UTC (permalink / raw)
To: Gleb Natapov; +Cc: Alexander Graf, kvm-ppc, KVM list
On Jan 21, 2013, at 5:40 AM, Gleb Natapov <gleb@redhat.com> wrote:
> On Fri, Jan 18, 2013 at 07:23:53AM -0500, Ben Collins wrote:
>> On Jan 18, 2013, at 7:14 AM, Alexander Graf <agraf@suse.de> wrote:
>>
>>>
>>> On 18.01.2013, at 11:55, Gleb Natapov wrote:
>>>
>>>> On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
>>>>> Hi Marcelo / Gleb,
>>>>>
>>>>> This is my current patch queue for ppc against 3.8. Please pull.
>>>>>
>>>>> It contains a bug fix for an issue that Ben Collins ran into, where
>>>>> a guest would just abort because it traps during an unknown instruction.
>>>>>
>>>> Is this regression from 3.7? If it is not it should wait for 3.9.
>>>
>>> The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.
>>
>> It's such a simple change, what is the issue with including it? If the bug is hit, qemu/kvm exits anyway, so adding the patch can't do any damage.
>>
> If we continue pushing simple changes that can't do any damage to
> late -rc trees 3.8 will never be ready to released. The patch can go to
> stable after 3.8 is released. Again if this is indeed regression this
> another matter.
It's indeed a regression for me. Where as QEmu used to work, now it doesn't. The regression appears to only occur when running 3.8 kernel in guest, which means the only way to run a 3.8 kernel in guest is with this patch.
--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-17 23:48 [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Alexander Graf
2013-01-17 23:48 ` [PATCH 1/1] KVM: PPC: Emulate dcbf Alexander Graf
2013-01-18 10:55 ` [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Gleb Natapov
@ 2013-01-21 23:36 ` Marcelo Tosatti
2013-01-24 18:23 ` Alexander Graf
2 siblings, 1 reply; 10+ messages in thread
From: Marcelo Tosatti @ 2013-01-21 23:36 UTC (permalink / raw)
To: Alexander Graf; +Cc: kvm-ppc, kvm
On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
> Hi Marcelo / Gleb,
>
> This is my current patch queue for ppc against 3.8. Please pull.
>
> It contains a bug fix for an issue that Ben Collins ran into, where
> a guest would just abort because it traps during an unknown instruction.
>
> Alex
>
>
> The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
> Linus Torvalds (1):
> Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs
>
> are available in the git repository at:
>
> git://github.com/agraf/linux-2.6.git kvm-ppc-3.8
>
> Alexander Graf (1):
> KVM: PPC: Emulate dcbf
>
> arch/powerpc/kvm/emulate.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Pulled, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-21 23:36 ` Marcelo Tosatti
@ 2013-01-24 18:23 ` Alexander Graf
2013-01-24 21:18 ` Gleb Natapov
0 siblings, 1 reply; 10+ messages in thread
From: Alexander Graf @ 2013-01-24 18:23 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: kvm-ppc, kvm
On 22.01.2013, at 00:36, Marcelo Tosatti wrote:
> On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
>> Hi Marcelo / Gleb,
>>
>> This is my current patch queue for ppc against 3.8. Please pull.
>>
>> It contains a bug fix for an issue that Ben Collins ran into, where
>> a guest would just abort because it traps during an unknown instruction.
>>
>> Alex
>>
>>
>> The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
>> Linus Torvalds (1):
>> Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs
>>
>> are available in the git repository at:
>>
>> git://github.com/agraf/linux-2.6.git kvm-ppc-3.8
>>
>> Alexander Graf (1):
>> KVM: PPC: Emulate dcbf
>>
>> arch/powerpc/kvm/emulate.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Pulled, thanks.
Into which queue? kvm.git doesn't contain it anywhere.
Alex
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8
2013-01-24 18:23 ` Alexander Graf
@ 2013-01-24 21:18 ` Gleb Natapov
0 siblings, 0 replies; 10+ messages in thread
From: Gleb Natapov @ 2013-01-24 21:18 UTC (permalink / raw)
To: Alexander Graf; +Cc: Marcelo Tosatti, kvm-ppc, kvm
On Thu, Jan 24, 2013 at 07:23:10PM +0100, Alexander Graf wrote:
>
> On 22.01.2013, at 00:36, Marcelo Tosatti wrote:
>
> > On Fri, Jan 18, 2013 at 12:48:25AM +0100, Alexander Graf wrote:
> >> Hi Marcelo / Gleb,
> >>
> >> This is my current patch queue for ppc against 3.8. Please pull.
> >>
> >> It contains a bug fix for an issue that Ben Collins ran into, where
> >> a guest would just abort because it traps during an unknown instruction.
> >>
> >> Alex
> >>
> >>
> >> The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
> >> Linus Torvalds (1):
> >> Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs
> >>
> >> are available in the git repository at:
> >>
> >> git://github.com/agraf/linux-2.6.git kvm-ppc-3.8
> >>
> >> Alexander Graf (1):
> >> KVM: PPC: Emulate dcbf
> >>
> >> arch/powerpc/kvm/emulate.c | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > Pulled, thanks.
>
> Into which queue? kvm.git doesn't contain it anywhere.
>
master.
--
Gleb.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-01-24 21:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-17 23:48 [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Alexander Graf
2013-01-17 23:48 ` [PATCH 1/1] KVM: PPC: Emulate dcbf Alexander Graf
2013-01-18 10:55 ` [PULL 3.8 0/1] ppc patch queue 2013-01-18 for 3.8 Gleb Natapov
2013-01-18 12:14 ` Alexander Graf
2013-01-18 12:23 ` Ben Collins
2013-01-21 10:40 ` Gleb Natapov
2013-01-21 12:15 ` Ben Collins
2013-01-21 23:36 ` Marcelo Tosatti
2013-01-24 18:23 ` Alexander Graf
2013-01-24 21:18 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox