From: Ralf Baechle <ralf@linux-mips.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: Sanjay Lal <sanjayl@kymasys.com>,
kvm@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures.
Date: Thu, 24 Jan 2013 14:22:06 +0100 [thread overview]
Message-ID: <20130124132206.GB28065@linux-mips.org> (raw)
In-Reply-To: <20121226131445.GH17584@redhat.com>
On Wed, Dec 26, 2012 at 03:14:45PM +0200, Gleb Natapov wrote:
> On Wed, Nov 21, 2012 at 06:34:00PM -0800, Sanjay Lal wrote:
> > +
> > +#ifndef __unused
> > +#define __unused __attribute__((unused))
> > +#endif
> > +
> There are __maybe_unused and __always_unused, no need to define your
> own.
Also the symbol __unused is a member of struct compat_flock in
<asm/compat.h> which is going to bite on 64 bit.
Ralf
next prev parent reply other threads:[~2013-01-24 13:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 2:33 [PATCH v2 00/18] KVM for MIPS32 Processors Sanjay Lal
2012-11-22 2:33 ` [PATCH v2 01/18] KVM/MIPS32: Infrastructure/build files Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures Sanjay Lal
2012-12-26 13:14 ` Gleb Natapov
2013-01-24 13:22 ` Ralf Baechle [this message]
2013-01-31 20:12 ` David Daney
2013-02-06 13:11 ` Gleb Natapov
2012-11-22 2:34 ` [PATCH v2 03/18] KVM/MIPS32: Entry point for trampolining to the guest and trap handlers Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 04/18] KVM/MIPS32: MIPS arch specific APIs for KVM Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 05/18] KVM/MIPS32: KVM Guest kernel support Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 06/18] KVM/MIPS32: Privileged instruction/target branch emulation Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 07/18] KVM/MIPS32: MMU/TLB operations for the Guest Sanjay Lal
2013-02-06 12:08 ` Gleb Natapov
2013-02-15 18:19 ` Sanjay Lal
2013-02-15 18:41 ` Gleb Natapov
2013-02-16 15:57 ` Sanjay Lal
2013-02-16 16:21 ` Gleb Natapov
2012-11-22 2:34 ` [PATCH v2 08/18] KVM/MIPS32: Release notes and KVM module Makefile Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 09/18] KVM/MIPS32: COP0 accesses profiling Sanjay Lal
2012-11-22 11:45 ` Sergei Shtylyov
2013-02-06 13:17 ` Gleb Natapov
2013-02-15 18:22 ` Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 10/18] KVM/MIPS32: Guest interrupt delivery Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 11/18] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest Sanjay Lal
2013-02-06 13:20 ` Gleb Natapov
2013-02-15 16:10 ` Sanjay Lal
2013-02-18 9:44 ` Gleb Natapov
2013-02-19 2:31 ` Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 12/18] MIPS: Export routines needed by the KVM module Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 13/18] MIPS: If KVM is enabled then use the KVM specific routine to flush the TLBs on a ASID wrap Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 14/18] MIPS: ASM offsets for VCPU arch specific fields Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 15/18] MIPS: Pull in MIPS fix: fix endless loop when processing signals for kernel tasks Sanjay Lal
2013-01-24 13:07 ` Ralf Baechle
2012-11-22 2:34 ` [PATCH v2 16/18] MIPS: Export symbols used by KVM/MIPS module Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 17/18] KVM/MIPS32: Do not call vcpu_load when injecting interrupts Sanjay Lal
2012-11-22 2:34 ` [PATCH v2 18/18] KVM/MIPS32: Binary patching of select privileged instructions Sanjay Lal
2012-11-26 18:53 ` [PATCH v2 00/18] KVM for MIPS32 Processors David Daney
2012-11-27 19:35 ` Sanjay Lal
2013-01-24 15:05 ` Ralf Baechle
2013-01-24 15:59 ` Sanjay Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124132206.GB28065@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).