From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH v2 00/18] KVM for MIPS32 Processors Date: Thu, 24 Jan 2013 16:05:18 +0100 Message-ID: <20130124150518.GA1593@linux-mips.org> References: <1353551656-23579-1-git-send-email-sanjayl@kymasys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org To: Sanjay Lal Return-path: Received: from arrakis.dune.hu ([78.24.191.176]:43780 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752920Ab3AXPFX (ORCPT ); Thu, 24 Jan 2013 10:05:23 -0500 Received: from localhost.localdomain ([127.0.0.1]:48280 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6833445Ab3AXPFVwrATM (ORCPT ); Thu, 24 Jan 2013 16:05:21 +0100 Content-Disposition: inline In-Reply-To: <1353551656-23579-1-git-send-email-sanjayl@kymasys.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Nov 21, 2012 at 06:33:58PM -0800, Sanjay Lal wrote: I've queued the patch set. I've done a few stylistic changes such as getting rid of all use of ulong and u_long data types in favor of unsigned long. I also ran into the following modpost error ERROR: "kvm_arch_vcpu_postcreate" [arch/mips/kvm/kvm.ko] undefined! which I fixed by adding a trivial kvm_arch_vcpu_postcreate function: int kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu) { return 0; } which may or may not be sufficient. Enabling CONFIG_KVM_MIPS_VZ was causing build errors. Since the support code for the VZ ASE is not part of this series, I've ripped that out entirely. As for the __unused references, some are indeed unused with no apparent reason for why the variables shouldn't be removed. There are also variables marked __unused which are being used - so no point in marking them. I've sorted that, too. Ralf