From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2 06/12] KVM: MMU: introduce a static table to map guest access to spte access Date: Thu, 24 Jan 2013 22:15:50 -0200 Message-ID: <20130125001550.GB22875@amt.cnet> References: <50FFB5A1.5090708@linux.vnet.ibm.com> <50FFB658.6040205@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Gleb Natapov , LKML , KVM To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60259 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754838Ab3AYAWy (ORCPT ); Thu, 24 Jan 2013 19:22:54 -0500 Content-Disposition: inline In-Reply-To: <50FFB658.6040205@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jan 23, 2013 at 06:07:20PM +0800, Xiao Guangrong wrote: > It makes set_spte more clean and reduces branch prediction > > Signed-off-by: Xiao Guangrong > --- > arch/x86/kvm/mmu.c | 37 ++++++++++++++++++++++++++----------- > 1 files changed, 26 insertions(+), 11 deletions(-) Don't see set_spte as being a performance problem? IMO the current code is quite simple.