From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi.kivity@gmail.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86 emulator: fix test_cc() build failure on i386
Date: Sun, 27 Jan 2013 11:20:08 +0200 [thread overview]
Message-ID: <20130127092008.GB31120@redhat.com> (raw)
In-Reply-To: <1359237364-17823-1-git-send-email-avi.kivity@gmail.com>
On Sat, Jan 26, 2013 at 11:56:04PM +0200, Avi Kivity wrote:
> 'pushq' doesn't exist on i386. Replace with 'push', which should work
> since the operand is a register.
>
> Signed-off-by: Avi Kivity <avi.kivity@gmail.com>
Applied, thanks.
> ---
> arch/x86/kvm/emulate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index e99fb72..2b11318 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -1013,7 +1013,7 @@ static u8 test_cc(unsigned int condition, unsigned long flags)
> void (*fop)(void) = (void *)em_setcc + 4 * (condition & 0xf);
>
> flags = (flags & EFLAGS_MASK) | X86_EFLAGS_IF;
> - asm("pushq %[flags]; popf; call *%[fastop]"
> + asm("push %[flags]; popf; call *%[fastop]"
> : "=a"(rc) : [fastop]"r"(fop), [flags]"r"(flags));
> return rc;
> }
> --
> 1.8.1
--
Gleb.
prev parent reply other threads:[~2013-01-27 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 21:56 [PATCH] KVM: x86 emulator: fix test_cc() build failure on i386 Avi Kivity
2013-01-27 9:20 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127092008.GB31120@redhat.com \
--to=gleb@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox