From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] KVM: x86 emulator: fix test_cc() build failure on i386 Date: Sun, 27 Jan 2013 11:20:08 +0200 Message-ID: <20130127092008.GB31120@redhat.com> References: <1359237364-17823-1-git-send-email-avi.kivity@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756292Ab3A0JUw (ORCPT ); Sun, 27 Jan 2013 04:20:52 -0500 Content-Disposition: inline In-Reply-To: <1359237364-17823-1-git-send-email-avi.kivity@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Jan 26, 2013 at 11:56:04PM +0200, Avi Kivity wrote: > 'pushq' doesn't exist on i386. Replace with 'push', which should work > since the operand is a register. > > Signed-off-by: Avi Kivity Applied, thanks. > --- > arch/x86/kvm/emulate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index e99fb72..2b11318 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -1013,7 +1013,7 @@ static u8 test_cc(unsigned int condition, unsigned long flags) > void (*fop)(void) = (void *)em_setcc + 4 * (condition & 0xf); > > flags = (flags & EFLAGS_MASK) | X86_EFLAGS_IF; > - asm("pushq %[flags]; popf; call *%[fastop]" > + asm("push %[flags]; popf; call *%[fastop]" > : "=a"(rc) : [fastop]"r"(fop), [flags]"r"(flags)); > return rc; > } > -- > 1.8.1 -- Gleb.