From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH 0/2] kvm: IOMMU read-only mapping support Date: Mon, 28 Jan 2013 21:25:43 +0900 Message-ID: <20130128212543.274a94d8021cfdabc3efc0e1@gmail.com> References: <20130124220027.11061.76400.stgit@bling.home> <20130125101704.b76b049d.yoshikawa_takuya_b1@lab.ntt.co.jp> <5101FBE8.9000206@linux.vnet.ibm.com> <20130128105903.GA22871@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , Takuya Yoshikawa , Alex Williamson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Gleb Natapov Return-path: In-Reply-To: <20130128105903.GA22871@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, 28 Jan 2013 12:59:03 +0200 Gleb Natapov wrote: > > It sets spte based on the old value that means the readonly flag check > > is missed. We need to call kvm_arch_flush_shadow_all under this case. > Why not just disallow changing memory region KVM_MEM_READONLY flag > without deleting the region? Sounds good. If you prefer, I can fold the required change into my patch. Takuya