From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v2 2/2] KVM: VMX: Add Posted Interrupt supporting
Date: Tue, 5 Feb 2013 09:49:31 +0200
Message-ID: <20130205074931.GA25100@redhat.com>
References: <1359968714-13820-1-git-send-email-yang.z.zhang@intel.com>
 <1359968714-13820-3-git-send-email-yang.z.zhang@intel.com>
 <20130204122835.GP23213@redhat.com>
 <A9667DDFB95DB7438FA9D7D576C3D87E0999A9A4@SHSMSX101.ccr.corp.intel.com>
 <20130205064501.GS23213@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Shan, Haitao" <haitao.shan@intel.com>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	"Zhang, Xiantao" <xiantao.zhang@intel.com>,
	"hpa@linux.intel.com" <hpa@linux.intel.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32101 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751256Ab3BEHtf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 5 Feb 2013 02:49:35 -0500
Content-Disposition: inline
In-Reply-To: <20130205064501.GS23213@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Feb 05, 2013 at 08:45:01AM +0200, Gleb Natapov wrote:
> > >> +	/* Posted interrupt descriptor */
> > >> +	struct pi_desc *pi;
> > >> +
> > > You haven't answered on my previous review why are you trying save 46
> > > bytes here.
> > Sorry. I cannot get your point. It's just a pointer and only takes 8 bytes.
> And embedded structure will take 64 bytes, so by allocating it dynamically
> you are trying to save 46 bytes for !pir case per vcpu. Just embed
> pi_desc here.
> 
My calculator is broken. It is 56 bytes of course. Still small enough to
embed.

--
			Gleb.