Re: [PATCH 2/2] x86, apicv: Add Posted Interrupt supporting

Gleb Natapov
2013-01-31T07:35:24Z

On Wed, Jan 30, 2013 at 09:03:11PM -0200, Marcelo Tosatti wrote:
> Some comments:
>
> Enable ack-on-exit feature patch:
> 1) Value of register VM_EXIT_INTR_INFO is available at
> vmx->exit_intr_info. See commit
> 887864758580c80710947c38a4692032163777df.
>
It is available only for EXIT_REASON_MCE_DURING_VMENTRY and
EXIT_REASON_EXCEPTION_NMI exit reasons. To use vmx->exit_intr_info
it needs to be updated on EXIT_REASON_EXTERNAL_INTERRUPT
too and vmx_handle_external_intr() will have to check that
vmx->exit_reason == EXIT_REASON_EXTERNAL_INTERRUPT before using it.

--
Gleb.