From: Gleb Natapov <gleb@redhat.com>
To: Yang Zhang <yang.z.zhang@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM : VMX: disable apicv by default
Date: Sun, 10 Feb 2013 11:16:08 +0200 [thread overview]
Message-ID: <20130210091608.GM7837@redhat.com> (raw)
In-Reply-To: <1360370746-32639-1-git-send-email-yang.z.zhang@intel.com>
On Sat, Feb 09, 2013 at 08:45:46AM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> Without Posted Interrupt, current code is broken. Just disable by
> default until Posted Interrupt is ready.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index fe9a9cf..27233a1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -84,7 +84,7 @@ module_param(vmm_exclusive, bool, S_IRUGO);
> static bool __read_mostly fasteoi = 1;
> module_param(fasteoi, bool, S_IRUGO);
>
> -static bool __read_mostly enable_apicv_reg_vid = 1;
> +static bool __read_mostly enable_apicv_reg_vid;
> module_param(enable_apicv_reg_vid, bool, S_IRUGO);
There is not point to let user enable broken option. Drop the module
parameter for now too.
--
Gleb.
prev parent reply other threads:[~2013-02-10 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 0:45 [PATCH] KVM : VMX: disable apicv by default Yang Zhang
2013-02-10 9:16 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210091608.GM7837@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox