* [PATCH] KVM : VMX: disable apicv by default
@ 2013-02-09 0:45 Yang Zhang
2013-02-10 9:16 ` Gleb Natapov
0 siblings, 1 reply; 2+ messages in thread
From: Yang Zhang @ 2013-02-09 0:45 UTC (permalink / raw)
To: kvm; +Cc: gleb, Yang Zhang
From: Yang Zhang <yang.z.zhang@Intel.com>
Without Posted Interrupt, current code is broken. Just disable by
default until Posted Interrupt is ready.
Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
---
arch/x86/kvm/vmx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index fe9a9cf..27233a1 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -84,7 +84,7 @@ module_param(vmm_exclusive, bool, S_IRUGO);
static bool __read_mostly fasteoi = 1;
module_param(fasteoi, bool, S_IRUGO);
-static bool __read_mostly enable_apicv_reg_vid = 1;
+static bool __read_mostly enable_apicv_reg_vid;
module_param(enable_apicv_reg_vid, bool, S_IRUGO);
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM : VMX: disable apicv by default
2013-02-09 0:45 [PATCH] KVM : VMX: disable apicv by default Yang Zhang
@ 2013-02-10 9:16 ` Gleb Natapov
0 siblings, 0 replies; 2+ messages in thread
From: Gleb Natapov @ 2013-02-10 9:16 UTC (permalink / raw)
To: Yang Zhang; +Cc: kvm
On Sat, Feb 09, 2013 at 08:45:46AM +0800, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> Without Posted Interrupt, current code is broken. Just disable by
> default until Posted Interrupt is ready.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index fe9a9cf..27233a1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -84,7 +84,7 @@ module_param(vmm_exclusive, bool, S_IRUGO);
> static bool __read_mostly fasteoi = 1;
> module_param(fasteoi, bool, S_IRUGO);
>
> -static bool __read_mostly enable_apicv_reg_vid = 1;
> +static bool __read_mostly enable_apicv_reg_vid;
> module_param(enable_apicv_reg_vid, bool, S_IRUGO);
There is not point to let user enable broken option. Drop the module
parameter for now too.
--
Gleb.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-10 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-09 0:45 [PATCH] KVM : VMX: disable apicv by default Yang Zhang
2013-02-10 9:16 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox