From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] KVM : VMX: disable apicv by default Date: Sun, 10 Feb 2013 11:16:08 +0200 Message-ID: <20130210091608.GM7837@redhat.com> References: <1360370746-32639-1-git-send-email-yang.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Yang Zhang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59825 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497Ab3BJJQL (ORCPT ); Sun, 10 Feb 2013 04:16:11 -0500 Content-Disposition: inline In-Reply-To: <1360370746-32639-1-git-send-email-yang.z.zhang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Feb 09, 2013 at 08:45:46AM +0800, Yang Zhang wrote: > From: Yang Zhang > > Without Posted Interrupt, current code is broken. Just disable by > default until Posted Interrupt is ready. > > Signed-off-by: Yang Zhang > --- > arch/x86/kvm/vmx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index fe9a9cf..27233a1 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -84,7 +84,7 @@ module_param(vmm_exclusive, bool, S_IRUGO); > static bool __read_mostly fasteoi = 1; > module_param(fasteoi, bool, S_IRUGO); > > -static bool __read_mostly enable_apicv_reg_vid = 1; > +static bool __read_mostly enable_apicv_reg_vid; > module_param(enable_apicv_reg_vid, bool, S_IRUGO); There is not point to let user enable broken option. Drop the module parameter for now too. -- Gleb.