From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>
Cc: Bharat Bhushan <r65777@freescale.com>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
Bharat Bhushan <bharat.bhushan@freescale.com>
Subject: Re: [PATCH 4/8] Added ONE_REG interface for debug instruction
Date: Mon, 11 Feb 2013 11:22:35 +1100 [thread overview]
Message-ID: <20130211002235.GA32734@drongo> (raw)
In-Reply-To: <40A423D4-6230-4ED5-A1EB-6589E7016DE4@suse.de>
On Thu, Feb 07, 2013 at 03:29:50PM +0100, Alexander Graf wrote:
>
> On 04.02.2013, at 01:41, Paul Mackerras wrote:
>
> > On Wed, Jan 16, 2013 at 01:54:41PM +0530, Bharat Bhushan wrote:
> >> This patch adds the one_reg interface to get the special instruction
> >> to be used for setting software breakpoint from userspace.
> >
> > Since this presumably is constant for any given platform, wouldn't
> > a capability be more appropriate?
>
> How so? A capability only tells you "I can do debug". Or "I can do debug on e500". I don't want to reteach QEMU how to do debug for every core we implement.
Capabilities aren't just binary - the get-capability (check_extension)
ioctl returns a 32-bit value, and we already have some that return
values other than 0 or 1. So I was thinking that we could add a
capability which when queried returns the special instruction. It's
up to you whether you want to do it that way or not.
Paul.
next prev parent reply other threads:[~2013-02-11 0:22 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 8:24 [PATCH 2/8] KVM: PPC: booke: Allow multiple exception types Bharat Bhushan
2013-01-16 8:24 ` [PATCH 3/8] KVM: PPC: booke: Added debug handler Bharat Bhushan
2013-01-25 11:42 ` Alexander Graf
2013-01-30 11:30 ` Bhushan Bharat-R65777
2013-01-31 12:17 ` Alexander Graf
2013-01-31 16:58 ` Bhushan Bharat-R65777
2013-01-31 17:08 ` Alexander Graf
2013-01-31 17:11 ` Alexander Graf
2013-02-01 5:04 ` Bhushan Bharat-R65777
2013-02-01 8:06 ` Alexander Graf
2013-02-01 9:07 ` Bhushan Bharat-R65777
2013-02-07 14:21 ` Alexander Graf
2013-02-07 14:48 ` Bhushan Bharat-R65777
2013-02-07 15:01 ` Alexander Graf
2013-01-16 8:24 ` [PATCH 4/8] Added ONE_REG interface for debug instruction Bharat Bhushan
2013-01-25 11:48 ` Alexander Graf
2013-01-31 17:44 ` Bhushan Bharat-R65777
2013-01-31 17:52 ` Alexander Graf
2013-01-31 17:58 ` Bhushan Bharat-R65777
2013-01-31 18:22 ` Alexander Graf
2013-02-04 0:41 ` Paul Mackerras
2013-02-07 14:29 ` Alexander Graf
2013-02-11 0:22 ` Paul Mackerras [this message]
2013-01-16 8:24 ` [PATCH 5/8] KVM: PPC: debug stub interface parameter defined Bharat Bhushan
2013-01-17 7:22 ` Paul Mackerras
2013-01-17 11:11 ` Bhushan Bharat-R65777
2013-01-25 11:53 ` Alexander Graf
2013-01-30 14:15 ` Bhushan Bharat-R65777
2013-01-31 13:01 ` Alexander Graf
2013-01-31 14:05 ` Bhushan Bharat-R65777
2013-01-31 14:27 ` Alexander Graf
2013-01-31 14:44 ` Bhushan Bharat-R65777
2013-01-16 8:24 ` [PATCH 6/8] booke: Added DBCR4 SPR number Bharat Bhushan
2013-01-16 8:24 ` [PATCH 7/8] KVM: PPC: booke/bookehv: Add debug stub support Bharat Bhushan
2013-01-25 12:07 ` Alexander Graf
2013-02-01 6:31 ` Bhushan Bharat-R65777
2013-02-01 8:21 ` Alexander Graf
2013-01-16 8:24 ` [PATCH 8/8] KVM:PPC:booke: Allow debug interrupt injection to guest Bharat Bhushan
2013-01-25 12:13 ` Alexander Graf
2013-01-30 11:12 ` Bhushan Bharat-R65777
2013-01-31 12:04 ` Alexander Graf
2013-01-31 17:59 ` Bhushan Bharat-R65777
2013-01-31 18:21 ` Alexander Graf
2013-01-31 18:43 ` Scott Wood
2013-01-31 18:52 ` Alexander Graf
2013-01-31 18:54 ` Scott Wood
2013-01-31 19:05 ` Alexander Graf
2013-01-31 19:20 ` Alexander Graf
2013-01-31 22:40 ` Scott Wood
2013-02-01 0:11 ` Alexander Graf
2013-02-01 22:38 ` Scott Wood
2013-02-04 4:48 ` Bhushan Bharat-R65777
2013-02-04 19:47 ` Scott Wood
2013-02-07 14:58 ` Alexander Graf
2013-02-07 15:25 ` Bhushan Bharat-R65777
2013-02-07 15:53 ` Alexander Graf
2013-02-07 15:00 ` Bhushan Bharat-R65777
2013-02-07 15:08 ` Alexander Graf
2013-01-31 18:03 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211002235.GA32734@drongo \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=bharat.bhushan@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=r65777@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox