From: Gleb Natapov <gleb@redhat.com>
To: "Nadav Har'El" <nyh@math.technion.ac.il>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH] KVM: nVMX: Rework event injection and recovery
Date: Thu, 21 Feb 2013 15:45:31 +0200 [thread overview]
Message-ID: <20130221134531.GA16817@redhat.com> (raw)
In-Reply-To: <20130221133716.GB8847@fermat.math.technion.ac.il>
On Thu, Feb 21, 2013 at 03:37:16PM +0200, Nadav Har'El wrote:
> On Thu, Feb 21, 2013, Jan Kiszka wrote about "Re: [PATCH] KVM: nVMX: Rework event injection and recovery":
> > That generally does not help to inject/report an external IRQ to L1 as
> > L1 runs with IRQs disabled around VMLAUNCH/RESUME.
>
> Good point, I forgot that :(
>
> So it looks like nested_run_pending was necessary, after all.
>
Not sure (as in "this is implementation detail that is possible to
avoid", not as in "this check here is incorrect!" :)). If interrupts
are disabled then vmx_interrupt_allowed() should return false because
interrupts are disabled, not because we emulating guest entry. This is
easier said that done though, but I'll think about it. Looks like SVM
does it this way.
--
Gleb.
next prev parent reply other threads:[~2013-02-21 13:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 13:01 [PATCH] KVM: nVMX: Rework event injection and recovery Jan Kiszka
2013-02-20 14:14 ` Nadav Har'El
2013-02-20 14:37 ` Jan Kiszka
2013-02-20 17:01 ` Gleb Natapov
2013-02-20 17:24 ` Jan Kiszka
2013-02-20 17:50 ` Jan Kiszka
2013-02-21 9:22 ` Gleb Natapov
2013-02-21 9:43 ` Jan Kiszka
2013-02-21 10:06 ` Gleb Natapov
2013-02-21 10:18 ` Jan Kiszka
2013-02-21 10:28 ` Jan Kiszka
2013-02-21 10:33 ` Jan Kiszka
2013-02-21 13:13 ` Gleb Natapov
2013-02-21 13:22 ` Jan Kiszka
2013-02-21 13:37 ` Nadav Har'El
2013-02-21 13:45 ` Gleb Natapov [this message]
2013-02-21 13:28 ` Nadav Har'El
2013-02-20 14:53 ` Jan Kiszka
2013-02-20 15:30 ` Gleb Natapov
2013-02-20 15:51 ` Jan Kiszka
2013-02-20 15:57 ` Gleb Natapov
2013-02-20 16:00 ` Jan Kiszka
2013-02-20 16:46 ` Gleb Natapov
2013-02-20 16:48 ` Jan Kiszka
2013-02-20 16:51 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221134531.GA16817@redhat.com \
--to=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nyh@math.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox