From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"avi.kivity@gmail.com" <avi.kivity@gmail.com>,
"Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [PATCH v4 2/2] KVM: VMX: Add Posted Interrupt supporting
Date: Sat, 23 Feb 2013 16:52:59 -0300 [thread overview]
Message-ID: <20130223195259.GA24760@amt.cnet> (raw)
In-Reply-To: <20130223194214.GD25155@redhat.com>
On Sat, Feb 23, 2013 at 09:42:14PM +0200, Gleb Natapov wrote:
> > explanation why its believed to be benign (given how the injection
> > return value is interpreted) could also work. Its ugly, though... murphy
> > is around.
> The race above is not benign. It will report interrupt as coalesced
> while in reality it is injected. This may cause to many interrupt to be
> injected. If this happens rare enough ntp may be able to fix time drift
> resulted from this.
OK.
> > OTOH spinlock is not the end of the world, can figure out something later
> > (we've tried without success so far).
> It serializes all injections into vcpu. I do not believe now that even
> with lock we are safe for the reason I mention above. We can use pir->on
> bit as a lock, but that only emphasise how ridiculous serialization of
> injections becomes.
Please review the 2nd iteration of pseudocode in patchset v4 thread, it
should be good.
next prev parent reply other threads:[~2013-02-23 19:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 13:42 [PATCH v4 0/2] KVM: VMX: Add Posted Interrupt supporting Yang Zhang
2013-02-22 13:42 ` [PATCH v4 1/2] KVM: VMX: enable acknowledge interupt on vmexit Yang Zhang
2013-02-22 13:42 ` [PATCH v4 2/2] KVM: VMX: Add Posted Interrupt supporting Yang Zhang
2013-02-23 13:43 ` Marcelo Tosatti
2013-02-23 14:05 ` Zhang, Yang Z
2013-02-23 14:35 ` Gleb Natapov
2013-02-23 14:48 ` Marcelo Tosatti
2013-02-23 15:31 ` Gleb Natapov
2013-02-23 17:05 ` Marcelo Tosatti
2013-02-23 19:42 ` Gleb Natapov
2013-02-23 19:52 ` Marcelo Tosatti [this message]
2013-02-23 19:59 ` Gleb Natapov
2013-02-24 13:55 ` Zhang, Yang Z
2013-02-24 14:19 ` Gleb Natapov
2013-02-24 14:26 ` Zhang, Yang Z
2013-02-24 14:39 ` Gleb Natapov
2013-02-24 18:08 ` Marcelo Tosatti
2013-02-24 18:59 ` Avi Kivity
2013-02-25 8:42 ` Zhang, Yang Z
2013-02-25 11:01 ` Gleb Natapov
2013-02-25 11:04 ` Zhang, Yang Z
2013-02-25 11:07 ` Gleb Natapov
2013-02-25 11:13 ` Zhang, Yang Z
2013-02-25 12:49 ` Marcelo Tosatti
2013-02-25 12:52 ` Zhang, Yang Z
2013-02-25 13:34 ` Gleb Natapov
2013-02-25 14:00 ` Marcelo Tosatti
2013-02-25 14:17 ` Marcelo Tosatti
2013-02-25 17:40 ` Gleb Natapov
2013-02-25 22:29 ` Marcelo Tosatti
2013-02-25 16:50 ` Avi Kivity
2013-02-25 17:43 ` Gleb Natapov
2013-02-25 18:56 ` Avi Kivity
2013-02-25 19:01 ` Gleb Natapov
2013-02-26 8:12 ` Gleb Natapov
2013-02-26 16:13 ` Avi Kivity
2013-02-24 17:44 ` Marcelo Tosatti
2013-02-25 7:24 ` Zhang, Yang Z
2013-02-23 14:44 ` Marcelo Tosatti
2013-02-23 15:16 ` Zhang, Yang Z
2013-02-23 16:50 ` Marcelo Tosatti
2013-02-24 13:17 ` Zhang, Yang Z
2013-02-24 17:39 ` Marcelo Tosatti
2013-02-25 6:55 ` Zhang, Yang Z
2013-02-25 13:01 ` Marcelo Tosatti
2013-02-25 14:32 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223195259.GA24760@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=xiantao.zhang@intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox